[4.0.0] Bug in AbstractView.updateIndexes

[Tweak]

Thanks westy, you saved me a lot of time

[yAdEs]

great guy！

[mikhailt]

Still there in 4.1.1...
The issue is that sometimes records[i] is outside of the bounds of the collection.
here

ns[i].viewRecordId = records[i].internalId;

It can be fixed with

endIndex = endIndex || ((endIndex === 0) ? 0 : (ns.length < records.length?(ns.length - 1):records.length-1) );

It is a problem with ItemSelector. Just try to update a store for an ItemSelector then the index records[i] is out of bounds.

[hagak]

I had to use the override that mkkhailt suggested in order to be able to load a node. I am using EXT JS 4.1.3 which I believe is the latest as of today.

One clue may be that if didn't seem to happen for nodes that were not that deep. Nodes that were 2 levels done could be loaded fine without the override. Nodes 5 levels down could not. I didn't test what happens for nodes 3 or 4 levels down because my tree isn't setup that.

[mgallagher]

Hi,

Just keeping this post alive, as I'm still experiencing this problem in 4.1.1a:
http://jsfiddle.net/beB7N/

Open the A node, then open the B node.

The console output is:
Uncaught TypeError: Cannot read property 'internalId' of undefined

The error occurs in Ext.view.AbstractView.updateIndexes()

Thanks
Mike

[evant]

The id's in the tree need to be unique, that's why you're seeing the error.

[mgallagher]

Thanks, you're right, it's not a bug

[mono blaine]

In my case the problem is caused by some of the suspended store events.

I had the following code:

store.suspendEvents();

while (store.getCount() > 0) {
    store.remove(store.last());
}

store.resumeEvents();
store.fireEvent("datachanged", store);
grid.getView().refresh();

My store was a local filtered store so I couldn't use store.removeAll() and also the events happening with respect to the removal of a record were too costly. So I suspended the store events, did what I had to do (later changed this to store.remove(store.getRange())), and resumed the store events. After that, I thought firing the datachanged event of the store and refreshing the grid view was enough in order to make things right.

It seems it's not. Because as seen below, Ext.view.AbstractView does not listen to the datachanged event of its store.

getStoreListeners: function() {
    var me = this;
    return {
        refresh: me.onDataRefresh,
        add: me.onAdd,
        remove: me.onRemove,
        update: me.onUpdate,
        clear: me.refresh
    };
}

Because of my interference with store events, the grid view does not get informed with the record changes, and updateIndexes method fails weirdly.

I think AbstractView should also listen to the datachanged event of the store.