Ext.data.validations presence function return false for numerfields with "0" values

[meditecsports]

Browsers: Firefox 4.0 and Google Chrome 10.0.648.127.
ExtJs version 4.0.2a.

There is a problem with Ext.data.Model validation type = "presence" when using numberfield. In this case it validation for value "0" is false.

For example this code:

Ext.define('Number', {
                extend: 'Ext.data.Model',
                fields: [
                    {name: 'number', type: 'int'}
                ],
                validations: [
                    {type: 'presence', field: 'number'}
                ]
            });

            var instance = Ext.ModelManager.create({
                number: 0
            }, 'Number');

            var errors = instance.validate();
            errors.isValid(); //false
            errors.getByField('number'); // [{field: 'number',  message: 'must be present'}] 

I think presence function does not count cases of int type fields validation.

[mitchellsimoens]

Thank you for the bug report. Please note that we have a new bug template and would appreciate if you could use this from now on.

[Nickname]

Just ran into the same problem



REQUIRED INFORMATION Ext version tested:

• Ext 4.0.2a

Browser versions tested against:

• FF4 (firebug 1.7 installed)

Description:

• Presence Validator fails if value is zero

Steps to reproduce the problem:

• Define a model validator with presence validator for a field
• Field value to validate is (int) 0

The result that was expected:

• The validator should return "true" because zero can be a wanted value for a field (like numberfield)

The result that occurs instead:

• Validator returns "false"

Test Case: (from initial reporter meditecsports)

 Ext.define('Number', {
    extend: 'Ext.data.Model',
fields: [
{name: 'number', type: 'int'}
],
    validations: [
{type: 'presence', field: 'number'}
    ]
});

var instance = Ext.ModelManager.create({
    number: 0
}, 'Number');

var errors = instance.validate();
errors.isValid(); //false
errors.getByField('number'); // [{field: 'number',  message: 'must be present'}]  

HELPFUL INFORMATION Debugging already done:

• in Ext.data.validations, the method "presence" is using "!!value", which is false if value is 0
• example: !!0 === false

Possible fix:

• in Ext.data.validations.presence():
• maybe "return !Ext.isEmpty(value)" ?!
  /**
  * Validates that the given value is present
  * @param {Object} config Optional config object
  * @param {Mixed} value The value to validate
  * @return {Boolean} True if validation passed
  */
  presence: function(config, value) {
  if (value === undefined) {
  value = config;
  }
  
  return !Ext.isEmpty(value);
  },

Operating System:

• Ubuntu 10.10

//edit: Oh, there is already a bug id for this, did not see that

//edit2: if you don't want to change the Ext source, you can use a format validator as a temporary fix

validations: [
        {type: 'format', field: 'number', matcher: /^\d+$/}
    ] 

[zodeus]

I can confirm this is an issue in 4.0.4, the presence method for what ever reason is return the value of the field rather than a true so if the field is an int with a zero or a boolean value of false it will always fail. Looking at the other validation methods they are returning either true or false, however the presence method returns either the value on success or the config on failure which seems inconsistent with the other validation methods.

[edspencer]

Thanks, this is now fixed in the 4.1.0 branch