Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member
    Join Date
    Nov 2009
    Location
    Münster
    Posts
    16
    Vote Rating
    0
    Stephan Stückmann is on a distinguished road

      0  

    Default [FNR] Grid sort state not apllied

    [FNR] Grid sort state not apllied


    Hi,

    we have a problem with applying the saved sort state of our grid, which uses clientside paging with a PagingModelMemoryProxy and BasePagingLoader.

    In Grid.doApplyStoreState() there is this line:

    Code:
    if (store.getLoader() == null && sortField != null)...
    I think this should be:

    Code:
    if ((store.getLoader() == null || !store.getLoader().isRemoteSort()) && sortField != null)...
    Or just skip the loader check, because in ListStore.sort() there is a check for the loader already?

    Kind regards,

    Stephan

  2. #2
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Or just skip the loader check, because in ListStore.sort() there is a check for the loader already?
    This is going to be a braking change.


    However i will add the check if its not using remote sort as this is realy missing

  3. #3
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Code:
    Index: user/src/com/extjs/gxt/ui/client/widget/grid/Grid.java
    ===================================================================
    --- user/src/com/extjs/gxt/ui/client/widget/grid/Grid.java	(revision 2379)
    +++ user/src/com/extjs/gxt/ui/client/widget/grid/Grid.java	(working copy)
    @@ -746,7 +746,7 @@
     
       protected void doApplyStoreState(Map<String, Object> state) {
         String sortField = (String) state.get("sortField");
    -    if (store.getLoader() == null && sortField != null) {
    +    if ((store.getLoader() == null || !store.getLoader().isRemoteSort()) && sortField != null) {
           String sortDir = (String) state.get("sortDir");
           SortDir dir = SortDir.findDir(sortDir);
           store.sort(sortField, dir);

  4. #4
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Fixed in SVN as of revision 2415

  5. #5
    Ext JS Premium Member
    Join Date
    Nov 2009
    Location
    Münster
    Posts
    16
    Vote Rating
    0
    Stephan Stückmann is on a distinguished road

      0  

    Default


    That was fast, thanks!

Thread Participants: 1

Turkiyenin en sevilen filmlerinin yer aldigi xnxx internet sitemiz olan ve porn sex tarzi bir site olan mobil porno izle sitemiz gercekten dillere destan bir durumda herkesin sevdigi bir site olarak tarihe gececege benziyor. Sitenin en belirgin ozelliklerinden birisi de Turkiyede gercekten kaliteli ve muntazam, duzenli porno izle siteleri olmamasidir. Bu yuzden iste. Ayrica en net goruntu kalitesine sahip adresinde yayinlanmaktadir. Mesela diğer sitelerimizden bahsedecek olursak, en iyi hd porno video arşivine sahip bir siteyiz. "The Best anal porn videos and slut anus, big asses movies set..." hd porno faketaxi