-
22 Jul 2011 11:48 AM #1
[4.0.1] Ext.grid.plugin.RowEditing errorSummary=true doesn't prevent all tooltips
[4.0.1] Ext.grid.plugin.RowEditing errorSummary=true doesn't prevent all tooltips
Ext.grid.plugin.RowEditing sets errorSummary on Ext.grid.RowEditor in its initEditor function.
RowEditor honors errorSummary in the onFieldChange function, but doesn't check for it in the loadRecord and beforeEdit functions.
So even if errorSummary is set to false, when editing a grid, if a field is marked as allowBlank: false but is blank, then the summary tooltip is shown since loadRecord is calling showToolTip() without checking for errorSummary.
-
22 Jul 2011 1:47 PM #2
providing a test case, even for issues that seem to be obvious, helps us process bug reports efficiently.
-
22 Jul 2011 1:55 PM #3
Test Case
Test Case
1. Enter row 2 and erase "Bart" which should trigger onFieldChange(). Confirm that the tooltip doesn't show. Hit Cancel.Code:Ext.create('Ext.data.Store', { storeId:'simpsonsStore', fields:['name', 'email', 'phone'], data:{'items':[ {"name":"", "email":"lisa@simpsons.com", "phone":"555-111-1224"}, {"name":"Bart", "email":"bart@simpsons.com", "phone":"555--222-1234"}, {"name":"Homer", "email":"home@simpsons.com", "phone":"555-222-1244"}, {"name":"Marge", "email":"marge@simpsons.com", "phone":"555-222-1254"} ]}, proxy: { type: 'memory', reader: { type: 'json', root: 'items' } } }); Ext.create('Ext.grid.Panel', { title: 'Simpsons', store: Ext.data.StoreManager.lookup('simpsonsStore'), columns: [ {header: 'Name', dataIndex: 'name', field: {xtype: 'textfield', allowBlank: false}}, {header: 'Email', dataIndex: 'email', flex:1, editor: { xtype:'textfield', allowBlank:false } }, {header: 'Phone', dataIndex: 'phone'} ], selType: 'rowmodel', plugins: [ Ext.create('Ext.grid.plugin.RowEditing', { clicksToEdit: 1, errorSummary: false }) ], height: 200, width: 400, renderTo: Ext.getBody() });
2. Enter row 1. Confirm that tooltip shows.
Desired:
Enter row 1. Tooltip should not show.
-
22 Jul 2011 2:46 PM #4
thank you, bug filed as EXTJSIV-3556
-
4 Oct 2011 6:56 AM #5
In Function loadRecord of Ext.grid.RowEditor errorSummary isn't asked to show the tooltip.
-
5 Oct 2011 12:40 AM #6
Evan Trimboli
Sencha Developer
Twitter - @evantrimboli
Don't be afraid of the source code!
This duplicates another bug already reported in our system:
EXTJSIV-3556


Reply With Quote