This duplicates another bug already reported in our system: EXTJS-3556
  1. #1
    Touch Premium Member
    Join Date
    Jun 2011
    Posts
    20
    Vote Rating
    0
    snoorani is on a distinguished road

      0  

    Default [4.0.1] Ext.grid.plugin.RowEditing errorSummary=true doesn't prevent all tooltips

    [4.0.1] Ext.grid.plugin.RowEditing errorSummary=true doesn't prevent all tooltips


    Ext.grid.plugin.RowEditing sets errorSummary on Ext.grid.RowEditor in its initEditor function.

    RowEditor honors errorSummary in the onFieldChange function, but doesn't check for it in the loadRecord and beforeEdit functions.

    So even if errorSummary is set to false, when editing a grid, if a field is marked as allowBlank: false but is blank, then the summary tooltip is shown since loadRecord is calling showToolTip() without checking for errorSummary.

  2. #2
    Sencha - Support Team mike.estes's Avatar
    Join Date
    Mar 2011
    Location
    Redwood City, CA
    Posts
    221
    Vote Rating
    9
    mike.estes will become famous soon enough

      0  

    Default


    providing a test case, even for issues that seem to be obvious, helps us process bug reports efficiently.

  3. #3
    Touch Premium Member
    Join Date
    Jun 2011
    Posts
    20
    Vote Rating
    0
    snoorani is on a distinguished road

      0  

    Default Test Case

    Test Case


    Code:
    Ext.create('Ext.data.Store', {
        storeId:'simpsonsStore',
        fields:['name', 'email', 'phone'],
        data:{'items':[
            {"name":"", "email":"lisa@simpsons.com", "phone":"555-111-1224"},
            {"name":"Bart", "email":"bart@simpsons.com", "phone":"555--222-1234"},
            {"name":"Homer", "email":"home@simpsons.com", "phone":"555-222-1244"},
            {"name":"Marge", "email":"marge@simpsons.com", "phone":"555-222-1254"}
        ]},
        proxy: {
            type: 'memory',
            reader: {
                type: 'json',
                root: 'items'
            }
        }
    });
    
    Ext.create('Ext.grid.Panel', {
        title: 'Simpsons',
        store: Ext.data.StoreManager.lookup('simpsonsStore'),
        columns: [
            {header: 'Name',  dataIndex: 'name', field: {xtype: 'textfield', allowBlank: false}},
            {header: 'Email', dataIndex: 'email', flex:1,
                editor: {
                    xtype:'textfield',
                    allowBlank:false
                }
            },
            {header: 'Phone', dataIndex: 'phone'}
        ],
        selType: 'rowmodel',
        plugins: [
            Ext.create('Ext.grid.plugin.RowEditing', {
                clicksToEdit: 1,
                errorSummary: false
            })
        ],
        height: 200,
        width: 400,
        renderTo: Ext.getBody()
    });
    1. Enter row 2 and erase "Bart" which should trigger onFieldChange(). Confirm that the tooltip doesn't show. Hit Cancel.

    2. Enter row 1. Confirm that tooltip shows.

    Desired:

    Enter row 1. Tooltip should not show.

  4. #4
    Sencha - Support Team mike.estes's Avatar
    Join Date
    Mar 2011
    Location
    Redwood City, CA
    Posts
    221
    Vote Rating
    9
    mike.estes will become famous soon enough

      0  

    Default


    thank you, bug filed as EXTJSIV-3556

  5. #5
    Ext JS Premium Member
    Join Date
    Mar 2011
    Posts
    46
    Vote Rating
    0
    Machiavelli79 is on a distinguished road

      0  

    Default


    In Function loadRecord of Ext.grid.RowEditor errorSummary isn't asked to show the tooltip.

  6. #6
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    17,067
    Vote Rating
    660
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    Dupe of: http://www.sencha.com/forum/showthread.php?132214

    This will be resolved in 4.1.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!