[1.1.0] Ext.regApplication is not compatible with application profiles

[welshcathy]

If you are using application profiles and Ext.regApplication there is a bug in Ext.Contoller.render()...
The bug is in setting a local variable profile as either the current profile string or the current application instance.
It then calls profile.getRenderTarget() which will obviously fail when the profile is set to a string!

See attached code (renamed to .js.txt for the uploader) for an example of the bug.

Work around if you still want to use profiles, use either:

MyApp = new Ext.Application({ ... });

or

MyAppDefinition = Ext.extend(Ext.Application, { ... });
MyApp = new MyAppDefinition();

Cheers,

Cathy

bug.js.txt

[SpyKeey]

Hello,

I have the same problem and I'm interested to know if there is any solution to keep the "Ext.regApplication" (for MVC) and still use "profiles:".

If I use any of your suggestions (new Ext.Application - or - Ext.extend(Ext.Application...)) then I will not be able to keep the current MVC structure of the application since I get the following error:

"Uncaught TypeError: Cannot read property 'viewport' of undefined"

I guess this means my viewport is not visible in Controllers anymore.

Thanks,

[welshcathy]

It's the controller that is missing a reference to the app.

You set it manually as follows:

In the Application

    launch: function() {


		// load styles by device
		Ext.Mobile.loadDeviceStylesheet('aps','pth');
    	Ext.Mobile.log('app launched ... ');
		
		Ext.dispatch({
			controller: 'MainController',
			action: 'doLaunch',
			app: this
		});  		
    	
    },

Then in the Controller method

    doLaunch: function(params){


    	// set up reference to application since we can't use regApplication
    	this.app = params.app;    
 	
       // etc etc ....
            	
    },

[SpyKeey]

Hello Cathy,

I tried the solution you suggested but I get the same error, maybe is something that I'm doing wrong or maybe my application structure is different, here you may see it:

File: App.js

Ext.regApplication({
  name: 'MyApp',
  defaultUrl: 'Home/index',


  launch: function()
  {
    // Init the Viewport
    this.viewport = new MyApp.views.Viewport();
  }, 
  
  profiles: {
    portraitPhone: function() {
      return Ext.is.Phone && Ext.orientation == 'portrait';
    },
    landscapePhone: function() {
      return Ext.is.Phone && Ext.orientation == 'landscape';
    },
    portraitTablet: function() {
      return !Ext.is.Phone && Ext.orientation == 'portrait';
    },
    landscapeTablet: function() {
      return !Ext.is.Phone && Ext.orientation == 'landscape';
    }
  }
});

File: HomeController.js

Ext.regController('Home', {
  // Index action
  index: function(options) {
    if (!this.indexView) {
      this.indexView = this.render({
        xtype: 'HomeIndex'
      });
    }
     
    this.application.viewport.setActiveItem(this.indexView, options.animation);
  }  
});

I have changed in "App.js" the "Ext.regApplication" to "new Ext.Application" and added your code to "launch:" (of course changing the controller name).

Then, in "HomeController.js" I have added your code for "doLaunch" and I still get the same error after I access the application in Google Chrome:

Uncaught TypeError: Cannot read property 'viewport' of undefined (HomeController.js:10)

This line here:

this.application.viewport.setActiveItem(this.indexView, options.animation);

[welshcathy]

Hiya,

Try changing theses lines in the controller doLaunch method

// set up reference to application since we can't use regApplication
this.app = params.app;

to

// set up reference to application since we can't use regApplication
this.application = params.app;

You can see in the error message you get that in the Controller (this) it is failing to find a reference to this.application not this.app as I had in my snippet.

Hint - in Chrome debugger in the Script panel you can set a break point to trigger before an exception is thrown - allowing you to inspect the relevant objects.
http://code.google.com/chrome/devtools/docs/scripts-breakpoints.html#js_exceptions

Good luck!

Cathy

[SpyKeey]

Hey Cathy,

Thanks for your time, help and hint. I will give it a shot later this afternoon and I will let you know if it works.

Thank you again for your time,

Luigi,

[Philip Murphy]

Hi Luigi - facing the same problem. Did this work for you in the end? I tried to change over to new Ext.Application, but I still see the problem.

As pointed out, in the Sencha render method the following code is broken as profile is a string at this point.

render: function(config, target) {
...
profileTarget = profile ? profile.getRenderTarget(config, application) : target;
....
}


Cheers,

Philip

PS thanks for posting work-around Cathy.

[jnotti]

Does anyone have any update on this, the work around didn't work for me. Perhaps we could modify the root of the problem itself?

Has anyone submitted a bug?

Sencha team, thoughts?

[jnotti]

BUMP!

[jnotti]

Can the Sencha team please acknowledge this bug?