Hybrid View

    Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Sencha User
    Join Date
    Oct 2011
    Posts
    127
    Vote Rating
    0
    robl is on a distinguished road

      0  

    Exclamation Ext.app.Controller bug in getModuleClassName ?

    Ext.app.Controller bug in getModuleClassName ?


    I'm not sure but I think there is a bug in getModuleClassName. this.name should be namespace.

    Code:
        getModuleClassName: function(name, type) {
            var namespace = Ext.Loader.getPrefix(name);
    
    
            if (namespace.length > 0 && namespace !== name) {
                return name;
            }
    
    
            return this.name + '.' + type + '.' + name;  // IS THIS A BUG?
            // Shouldn't it be:   return namespace +'.' + type + '.' + name;
        },

  2. #2
    Sencha - Sencha Touch Dev Team Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    Thank you for the report.

  3. #3
    Sencha User
    Join Date
    Apr 2011
    Location
    San Jose, California
    Posts
    1
    Vote Rating
    0
    rake is on a distinguished road

      0  

    Default Now same thing in Ext.app.Application [PR3]

    Now same thing in Ext.app.Application [PR3]


    Looking at this in PR3, getModuleClassName() is no longer in Ext.app.Controller, but has been moved to Ext.app.Application. But has exact same definition as what was classified here as a bug.

    Code:
    getModuleClassName: function(name, type) {
            var namespace = Ext.Loader.getPrefix( name );
            if (namespace.length > 0 && namespace !== name) {
                return name;
            }
            return this.name + '.' + type + '.' + name;
        }
    Other thing that looks fishy is that Ext.app.Controller appears to be aliased to Ext.Application. Beginning of Ext.app.Controller is as follows:

    Code:
    Ext.define( 'Ext.app.Controller', {
        alternateClassName: 'Ext.Application'
    Perhaps some hasty "cut-n-paste" refactoring??

  4. #4
    Sencha - Community Support Team edspencer's Avatar
    Join Date
    Jan 2009
    Location
    Palo Alto, California
    Posts
    1,939
    Vote Rating
    7
    edspencer is a jewel in the rough edspencer is a jewel in the rough edspencer is a jewel in the rough

      0  

    Default


    This has all been reworked for PR4. I'm closing the ticket because it works in a different way internally now
    Ext JS Senior Software Architect
    Personal Blog: http://edspencer.net
    Twitter: http://twitter.com/edspencer
    Github: http://github.com/edspencer

film izle

hd film izle

film sitesi

takipci kazanma sitesi

takipci kazanma sitesi

güzel olan herşey

takipci alma sitesi

komik eğlenceli videolar