1. #1
    Sencha User dobie_'s Avatar
    Join Date
    Sep 2011
    Location
    Seattle, WA
    Posts
    47
    Vote Rating
    0
    dobie_ is on a distinguished road

      0  

    Default ST2 community patches repository

    ST2 community patches repository


    The previous thread was closed... could a mod clarify why?

    https://github.com/mgcrea/sencha-touch

  2. #2
    Touch Premium Member lylepratt's Avatar
    Join Date
    Dec 2010
    Location
    Austin, Texas
    Posts
    159
    Vote Rating
    0
    lylepratt is on a distinguished road

      0  

    Default


    Its probably because you are distributing the full ST library which is probably against the licensing agreement. I believe Mitchell said something similar in your previous post.

    You should instead publish your changes Patches, Diffs, or Overrides. Modifying the core source of any library is generally bad practice as it makes staying up to date, applying, or unapplying the changes cumbersome as the core library team releases updates and fixes.

    I for one would not consider using your changes just because it directly modifies the source.
    Twitter: lylepratt

  3. #3
    Sencha User dobie_'s Avatar
    Join Date
    Sep 2011
    Location
    Seattle, WA
    Posts
    47
    Vote Rating
    0
    dobie_ is on a distinguished road

      0  

    Default


    Under the open source license: http://www.sencha.com/legal/open-source-faq/
    S
    encha actually states that they encourage posting patches to the Sencha forums, so I'm confused.

    As far as distributing the entire source instead of just the diffs.. All the diffs are listed in the Github commits section: https://github.com/mgcrea/sencha-touch/commits/master
    A
    nd the library is freely available for anyone to download from sencha.com, so what's wrong with making it available at different places around the Internet? Surely the Sencha team isn't able to keep track of all the places their javascript library is on the web.

  4. #4
    Touch Premium Member lylepratt's Avatar
    Join Date
    Dec 2010
    Location
    Austin, Texas
    Posts
    159
    Vote Rating
    0
    lylepratt is on a distinguished road

      0  

    Default


    Distributing the entire library is entirely different from distributing patches that you have written.

    Item 4, first sentence:
    http://www.sencha.com/legal/touch-commercial-license

    I'm not saying the patches you have written are not beneficial, I'm just guessing why the admins closed your thread and suggesting an alternate, much more accommodating way you could have posted your beneficial changes.
    Twitter: lylepratt

  5. #5
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    18
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    I've re-opened the thread. I don't think it's the best way to go, but we'll leave it to you.

    Sencha Inc

    Jamie Avins

    @jamieavins

  6. #6
    Sencha Premium Member
    Join Date
    Oct 2011
    Location
    Paris, France
    Posts
    187
    Vote Rating
    3
    olouvignes is on a distinguished road

      0  

    Default


    Again, this repo only aims at helping early adopters with blocking bugs preventing them to move to ST2.0, i guess the more people start using ST2.0 today, the more this (amazing) product gets a strong footprint on the web.

    I would rather publish plugins & extensions, but for now we are quite stuck with blocking bugs.

    I understand that this conflicts somehow with the global/commercial policy your company has, and i'm thankful i've not been asked to take it down yet, as I really think it is good for everyone at the moment.

    It is not aimed to last beyond beta, and it will be taken down if you want it to (your product / business -> your call).

    Regards,