Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Sencha User
    Join Date
    Oct 2011
    Posts
    6
    Vote Rating
    0
    alex.k is on a distinguished road

      0  

    Default Carousel indicator fails counting items

    Carousel indicator fails counting items


    REQUIRED INFORMATION


    Ext version tested:
    • Touch 2.0-pr1
    Browser versions tested against:
    • Chrome
    • FF3 (firebug 1.3.0.10 installed
    Description:
    • Removing an item from carsousel is adding an indicator, instead of removing one.
    Steps to reproduce the problem:
    • Run the code below
    The result that was expected:
    • Proper indicator count decreased
    The result that occurs instead:
    • Improper indicator count increased
    Test Case:

    Code:
    Ext.application({
        name: 'Sencha',
    
    
        launch: function() {
            var c = Ext.create("Ext.carousel.Carousel", {
                fullscreen: true,
                items: [{
                    title: 'Home',
                    iconCls: 'home',
                    html: 'Welcome'
                }, {
                    title: 'Home',
                    iconCls: 'home',
                    html: 'Sweet Welcome'
                }]
            });
            console.log(c.getItems().getCount()); // = 3, correct, 2 panels + indicator
            console.log(c.getIndicator().indicators.length); // =2, correct, 2 visible panels
            c.removeAt(0);
            console.log(c.getItems().getCount()); // = 2, correct, 1 panel + indicator
            console.log(c.getIndicator().indicators.length); // =3, wrong, i.e. indicator added instead of removed
            //NB: the problem is Carousel.js#216, inside onRemove : function...
            // line 216 reads : indicator.addIndicator();
            // should be: indicator.removeIndicator();
            // copy-pasted code from onAdd ??
        }
    });


    HELPFUL INFORMATION

    Debugging already done:
    • yes
    Possible fix:
    • fix Carousel.js #216: replace indicator.addIndicator() => indicator.removeIndicator()
    • fyi, this is inside onRemove : function()...
    Operating System:
    • WinXP Pro

  2. #2
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    20
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    This was resolved in PR2.

    Sencha Inc

    Jamie Avins

    @jamieavins

Thread Participants: 1

Tags for this Thread

Turkiyenin en sevilen filmlerinin yer aldigi xnxx internet sitemiz olan ve porn sex tarzi bir site olan mobil porno izle sitemiz gercekten dillere destan bir durumda herkesin sevdigi bir site olarak tarihe gececege benziyor. Sitenin en belirgin ozelliklerinden birisi de Turkiyede gercekten kaliteli ve muntazam, duzenli porno izle siteleri olmamasidir. Bu yuzden iste. Ayrica en net goruntu kalitesine sahip adresinde yayinlanmaktadir. Mesela diğer sitelerimizden bahsedecek olursak, en iyi hd porno video arşivine sahip bir siteyiz. "The Best anal porn videos and slut anus, big asses movies set..." hd porno faketaxi