Threaded View

    Success! Looks like we've fixed this one. According to our records the fix was applied for a bug in our system in a recent build.
  1. #1
    Sencha User
    Join Date
    Nov 2011
    Posts
    23
    Vote Rating
    0
    pete_by is on a distinguished road

      0  

    Exclamation TreeDragSource does not allow moving both the leafs and the nodes in same tree

    TreeDragSource does not allow moving both the leafs and the nodes in same tree


    Change: bug's title misses NOT word: "does NOT allow"

    Current implementation does not allow moving both leafs and nodes in the same tree. Only option is possible in the same time (even in single selection mode). This is because TreeDragSource#onDragStart method tests TreeSource only for LEAF or NODE, and not BOTH. This makes hard to implement editable hierarchies.

    Code:
     if (getTreeGridSource() == TreeSource.LEAF) { 
           ...
        } else { // else NODE or BOTH
        ...      
             for (M item : selected) {
                   if (getWidget().isLeaf(item)) { // here's the problem, we reject the leafs even                                                           // if getTreeGridSource()== BOTH
                event.setCancelled(true);
                        return;
                   } else {
                        nonLeafKeys.add(kp.getKey(item));
                   }
        ...
           }
    Last edited by pete_by; 29 Nov 2011 at 12:01 PM. Reason: title is incorrect