List doItemDselect

[mom_pece]

onItemDeselect: function(record, suppressEvent) {
var me = this;
if (suppressEvent) {
me.doItemDeSelect(me, record);

Last line should be doItemDeselect (note the spelling). For this reason List.deselect fails.

This is in PR3

[mitchellsimoens]

Test case?

[mom_pece]

Sorry for not providing test cases for these bugs, but I am currently on a very tight schedule here and don;t have much time to build them.

It this case I thought it'll be pretty obvious as the method in DataView.js is:

doItemDeselect: function(me, record) {
var item = Ext.get(me.getViewItems()[me.getStore().indexOf(record)]);
if (item) {
item.removeCls([me.getPressedCls(), me.getSelectedCls()]);
}
},

which has a different spelling. The method just above that one calls this one : me.doItemDeSelect(me, record);

Best regards,

Robert

[mitchellsimoens]

I see...

    // invoked by the selection model to maintain visual UI cues
    onItemDeselect: function(record, suppressEvent) {
        var me = this;
        if (suppressEvent) {
            me.doItemDeSelect(me, record);
        }
        else {
            me.fireAction('deselect', [me, record, suppressEvent], 'doItemDeselect');
        }
    },

    doItemDeselect: function(me, record) {
        var item = Ext.get(me.getViewItems()[me.getStore().indexOf(record)]);
        if (item) {
            item.removeCls([me.getPressedCls(), me.getSelectedCls()]);
        }
    },

The second one should be doItemDeSelect... gotcha!

[mitchellsimoens]

Sorry... I noted the spelling but not the case

[mom_pece]

No worries, my english is not the most expressive form of communication ever