Success! Looks like we've fixed this one. According to our records the fix was applied for TOUCH-1263 in a recent build.
  1. #1
    Touch Premium Member
    Join Date
    Sep 2011
    Posts
    22
    Vote Rating
    0
    mom_pece is on a distinguished road

      0  

    Default List doItemDselect

    List doItemDselect


    onItemDeselect: function(record, suppressEvent) {
    var me = this;
    if (suppressEvent) {
    me.doItemDeSelect(me, record);

    Last line should be doItemDeselect (note the spelling). For this reason List.deselect fails.

    This is in PR3

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    36,562
    Vote Rating
    814
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    Test case?
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  3. #3
    Touch Premium Member
    Join Date
    Sep 2011
    Posts
    22
    Vote Rating
    0
    mom_pece is on a distinguished road

      0  

    Default Test case

    Test case


    Sorry for not providing test cases for these bugs, but I am currently on a very tight schedule here and don;t have much time to build them.

    It this case I thought it'll be pretty obvious as the method in DataView.js is:

    doItemDeselect: function(me, record) {
    var item = Ext.get(me.getViewItems()[me.getStore().indexOf(record)]);
    if (item) {
    item.removeCls([me.getPressedCls(), me.getSelectedCls()]);
    }
    },

    which has a different spelling. The method just above that one calls this one : me.doItemDeSelect(me, record);

    Best regards,

    Robert

  4. #4
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    36,562
    Vote Rating
    814
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    I see...

    Code:
        // invoked by the selection model to maintain visual UI cues
        onItemDeselect: function(record, suppressEvent) {
            var me = this;
            if (suppressEvent) {
                me.doItemDeSelect(me, record);
            }
            else {
                me.fireAction('deselect', [me, record, suppressEvent], 'doItemDeselect');
            }
        },
    
        doItemDeselect: function(me, record) {
            var item = Ext.get(me.getViewItems()[me.getStore().indexOf(record)]);
            if (item) {
                item.removeCls([me.getPressedCls(), me.getSelectedCls()]);
            }
        },
    The second one should be doItemDeSelect... gotcha!
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  5. #5
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    36,562
    Vote Rating
    814
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    Sorry... I noted the spelling but not the case
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  6. #6
    Touch Premium Member
    Join Date
    Sep 2011
    Posts
    22
    Vote Rating
    0
    mom_pece is on a distinguished road

      0  

    Default


    No worries, my english is not the most expressive form of communication ever

Thread Participants: 1