[2.0b1/rc1][SOLVED] timeout at BasicForm never used

[ftftft]

I guess it is a bug at Ext code. Regardless what value I set to timeout, it is always 30 seconds.

BasicForm.js: (action='submit', options.timeout=40)

    
doAction : function(action, options){
        if(typeof action == 'string'){
            action = new Ext.form.Action.ACTION_TYPES[action](this, options);
        }

Action.js: (o.timeout = 40. but was never passed to Ext.Ajax.request).

    run : function(){
        var o = this.options;
        var method = this.getMethod();
        var isPost = method == 'POST';
        if(o.clientValidation === false || this.form.isValid()){
            Ext.Ajax.request(Ext.apply(this.createCallback(), {
                form:this.form.el.dom,
                url:this.getUrl(!isPost),
                method: method,
                params:isPost ? this.getParams() : null,
                isUpload: this.form.fileUpload
            }));

        }else if (o.clientValidation !== false){ // client validation failed
            this.failureType = Ext.form.Action.CLIENT_INVALID;
            this.form.afterAction(this, false);
        }

so, when go to ext-base.js, callback.timeout is always 30000, set by default.

        handleReadyState:function(o, callback)
        {
            var oConn = this;

            if (callback && callback.timeout) {
                this.timeout[o.tId] = window.setTimeout(function() {
                    oConn.abort(o, callback, true);
                }, callback.timeout);
            }

[jsakalos]

Hmmm,

what I read in the source:

    // private
    createCallback : function(){
        return {
            success: this.success,
            failure: this.failure,
            scope: this,
            timeout: (this.form.timeout*1000),
            upload: this.form.fileUpload ? this.success : undefined
        };
    } 

and

   // private
    run : function(){
        var o = this.options;
        var method = this.getMethod();
        var isPost = method == 'POST';
        if(o.clientValidation === false || this.form.isValid()){
            Ext.Ajax.request(Ext.apply(this.createCallback(), {
                form:this.form.el.dom,
                url:this.getUrl(!isPost),
                method: method,
                params:isPost ? this.getParams() : null,
                isUpload: this.form.fileUpload
            }));

        }else if (o.clientValidation !== false){ // client validation failed
            this.failureType = Ext.form.Action.CLIENT_INVALID;
            this.form.afterAction(this, false);
        }
    }, 

This is source from svn rev. 1344.

[ftftft]

Well. Let me go through code at SVN 1350.

Ext.data.Connection. Eventually, timeout is set to here.

Ext.extend(Ext.data.Connection, Ext.util.Observable, {
   timeout : 30000,
   request : function(o){
            var cb = {
                success: this.handleResponse,
                failure: this.handleFailure,
                scope: this,
                argument: {options: o},
                timeout : this.timeout --> That would be 30000, regardless what timeout value to be set in the form.  
            };

[ftftft]

Even this code has some problem. If I call,

this.formPanel.getForm().submit({timeout: ....}). the "timeout" value here would never be used.

    // private
    createCallback : function(){
        return {
            success: this.success,
            failure: this.failure,
            scope: this,
            timeout: (this.form.timeout*1000),
            upload: this.form.fileUpload ? this.success : undefined
        };
    }

[jsakalos]

Here you pass timeout in submit call config object. What if you assign a timeout at the FormPanel construction time as config option, still ignored?

Docs say it's config option of BasicForm.

[ftftft]

My code is like below. Both "timeout" parameter are ignored.

   this.filterForm = new Ext.FormPanel({
        url:'....',
        timeout: 400,
   } 
   this.filterForm.getForm().submit(
        { waitMsg: 'Retrieving transactions...',
          success: this.onLoadSuccess,
          failure: displayFailureMessage,
          timeout: 400,
          scope: this
        }
    );

more comments. timeout at Ext.data.Connection is a Constants at 30000(Aka. 30 seconds).

At, Ext.data.Connection. var cb = { time: this.timeout} -> 30000

Goto Ext.lib.Ajax

        handleReadyState:function(o, callback)
        {
            var oConn = this;

            if (callback && callback.timeout) { --> callback.timeout is cb.timeout at Ext.data.Connection
                put alert(callback.timeout) for a quick check.
                this.timeout[o.tId] = window.setTimeout(function() {
                    oConn.abort(o, callback, true);
                }, callback.timeout);
            }