4.1: Form/Field isDirty() shows false if field has no original value

**bclinton** · 1 Jan 2012 6:45 PM

Ext version tested:

Ext 4.0.7 and 4.1-PR1, 4.1.0-beta-1

Description:

The isDirty() function in Ext.form.field.Field has been changed in the 4.1 preview release and now reports that fields without an original value are not dirty when they have been changed .

Steps to reproduce the problem:

Make a form that contains fields without a default value, change one or more of those fields, test isDirty(), fields will not show as dirty

The result that was expected:

I expected fields that have been changed to show as dirty even if they had no original value.

The result that occurs instead:

Fields with no default value show will not show as dirty when their value has been changed

I'm not sure if this is a bug or if it is working as designed. The isDirty() function in Ext.form.field.Field has been changed in the 4.1 preview and beta releases.

This is the function in 4.07:

Code:

    isDirty : function() {
        var me = this;
        return !me.disabled && !me.isEqual(me.getValue(), me.originalValue);
    }

,
In the 4.1 PR1 and 4.1.0-beta-1, the function disregards changes in fields with an undefined originalValue:

Code:

    isDirty : function() {
        var me = this;
        return !me.disabled && typeof me.originalValue != 'undefined' && !me.isEqual(me.getValue(), me.originalValue);
    },

Test Case:
Here is a working test case for a simple form. Type something into the textfield and then click the button. In 4.0.7, the field/form isDirty function will report true. In 4.1-PR1 and 4.1.0-beta-1, the field/form isDirty function will report false because the originalValue is undefined.

Code:

<html>
<head>
    <title>Form dirty test</title>
</head>
<body>
<div id="form-div"</div>
<div id="script-div">


    <!-- ExtJS style sheets and library -->
    <link rel="stylesheet" type="text/css" href="lib/ext/resources/css/ext-all.css">
    <script type="text/javascript" src="lib/ext/ext-all-debug.js"></script>


    <script type="text/javascript">
    Ext.onReady(function() {


        Ext.create('Ext.form.Panel',{
            renderTo : 'form-div',
            height   : 160,
            width    : 320,
            title    : 'Test Form',
            items   : [
                {
                    // textfield has no initial value
                    name        : 'test',
                    fieldLabel  : 'type something here',
                    labelWidth  : 120,
                    xtype       : 'textfield'
                }
            ],
            buttons : [
            {
                text    : 'test dirty',
                listeners: {
                    click: function(button)
                    {
                        var form    = button.up('form'),
                            field   = form.down('textfield[name=test]');


                        Ext.Msg.alert('Info',
                            'field original value: '+field.originalValue+'<br />'+
                            'field current value: '+field.getValue()+'<br />'+
                            'form isDirty():'+form.getForm().isDirty()+'<br />'
                        );
                    }
                }
            }]
        });
    });
    </script>
</div>
</body>
</html>

**mitchellsimoens** · 2 Jan 2012 6:53 AM

Thank you for the report.

4.1: Form/Field isDirty() shows false if field has no original value

Thread Tools

Search Thread

Display

4.1: Form/Field isDirty() shows false if field has no original value

4.1: Form/Field isDirty() shows false if field has no original value