Inconsistent plugins in ExtJS 4

[chiragrp]

Hi,

I have used tow plugins for GridPanel. One is Ext.grid.plugin.CellEditing and the other is Ext.ux.RowExpander.

When creating GridPanel, I could specify CellEditing plugin as following:

plugins: [
Ext.create('Ext.grid.plugin.CellEditing', {
clicksToEdit: 1
})
]

I could not specify the RowExpander plugin in the same manner since it needs reference of the GridPanel instance.

My questions is that are there any reasons to have such inconsistent plugins?

Thanks

[skirtle]

I'm not sure what you mean. The RowExpander should be just the same, you shouldn't need a reference to the grid.

Take a look at the code for the demo:

http://dev.sencha.com/deploy/ext-4.0...d-plugins.html

[chiragrp]

The difference is that in case of CellEditing plugin, you can create an instance of the plugin and set it as config option for the GridPanel whereas in case of RowExpander it is not possible.
See the code below:

a) CellEditing:

plugins: [
Ext.create('Ext.grid.plugin.CellEditing', {
clicksToEdit: 1
})
]

b) RowExpander:

plugins: [{
            ptype: 'rowexpander',            rowBodyTpl : [                '<p><b>Company:</b> {company}</p><br>',                '<p><b>Summary:</b> {desc}</p>'            ]         }]

I hope example above is conveying what I want to say.

Thanks
Chirag

[skirtle]

I think I see what you mean. RowExpander needs the grid to be set in the constructor whereas CellEditing only needs it to be set by init time.

The first thing to note is that RowExpander is a UX so you should expect it to be less tidy than a proper part of the framework. I agree it would be better if you could create it separately using Ext.create.

There's a comment in the source of RowExpander that explain why it needs the grid at construction time. It's relying on the grid features mechanism and apparently that must be done before the plugin's init method is called.

The preferred method for creating plugins is to use the config-style. For CellEditing you should really be writing something like this:

plugins: [{
    ptype: 'cellediting',
    clicksToEdit: 1
}]

[chiragrp]

I see your point.

Thanks