Buttons don't return response object on success

[cyberwombat]

I have buttons to submit forms - it appears that the on success handler doesn't return a response object but the failure one does - is this intentional?

 onSubmitButtonTap: function(el) {
        var a = this;
        var f = this.getForm();
        f.submit({
            waitMsg: {
                message: 'Hold on...',
                cls: 'loading'
            },
           
            method: 'POST',
            success: function(frm, res) {
                 //res.responseText does not exist
            },
            failure: function(frm, res) {
                //this exists res.responseText
            }
        });

I have tested this many times by sending the same response for success/fail and only changing the response code from 200/400

[mitchellsimoens]

In PR3, the success and failure have the same arguments. The first is the form panel, the second is the response that is decoded so it's a JavaScript Object, the third is the response text undecoded.

form.submit({
    success : function(form, resObject, resText) {},
    failure : function(form, resObject, resText) {}
});

[cyberwombat]

Certainly not the case with me in PR3 - the second arg of the success is not a response object - it's just a plain object

[mitchellsimoens]

The 2nd argument is for me and is according to the docs as well. It was the JSON response decoded.

[cyberwombat]

It is the JSON response decoded - but the failure arg is not - it's a response object.

If I return a json array from my server such as:

{"success":true,"token":"example"}


In success, I access the token like this (assuming my second param is call 'res'):

res.token

In the failure on the other hand I need to do:

res.responseText.token

[mitchellsimoens]

If you return success as false, the failure callback should fire and, in my test, it was the decoded JSON string.

[cyberwombat]

I see the issue - ST doesn't handle a 400 response like a 200. I return a 400 on form fail which does return a different object - evidently this is an issue of sorts

http://www.sencha.com/forum/showthre...ation-response

[cyberwombat]

That link I posted above has sencha devs mentioning a possible flag to cause 400 to be parsed. Is this implemented in ST2?