[PR4] Scrolling a list doesn't work with 'id' property defined

[lebbers]

Version tested:

• ST2 PR4

Browser versions tested against:

• Google Chrome

Description:
After migrating from ST2 PR3 to PR4 I run in to a problem with scrolling a list. The list doesn't scroll when I set the 'id' property of the list in my own defined relationslist class (extending from Ext.dataview.list).
Without the 'id' property, scrolling the list works fine.


Test Case:

/** app.js **/
Ext.Loader.setConfig({ enabled: true });


Ext.application({
    name: 'CrmTouch',             //namespace and global variable


    models: [                
            'CrmRelationsModel' 
    ], 
    controllers: [                 
            'CrmRelationsController'
    ],       
   views: [    
            'CrmRelationsListView'
   ],                                  
    stores: [                
            'CrmRelationsDataStore'
    ],

    launch: function() {
         console.log('App launch');

          Ext.create('Ext.Container', {
          fullscreen: true,
                layout: 'fit',
                items: [
                {
                    xtype: 'CrmRelations'
                }]
        });           
    }  
});


/** CrmRelationsListView.js **/
Ext.define('CrmTouch.view.CrmRelationsListView', {
    extend: 'Ext.dataview.List',
        xtype: 'CrmRelations', 

        config: {
            id: 'CrmRelationsList', //<!-- causing the list scroll problem
            store: 'CrmRelationsDataStore',
            cls: 'CrmRelationsList',
            itemTpl: '<div class="CrmRelationsListItem"> <span class="FirstItem">{name}</span><span class="SecondItem">{location}</span> </div>',
            styleHtmlContent: true,
            mode: 'SINGLE'        
        }
    }
});

[Jamie Avins]

Thank you for the test case and report.

[Jamie Avins]

This has been fixed in the next release, but this pattern is not something we ever recommend. You should be passing an id at instantiation not baking it into a base class like this.

[lebbers]

I understand that it is not a good pattern to use and also not needed in my application. It's just something easily overlooked. Before I found out it was the id property I tested with different layout configs, reading a lot documentation and eventually stripping my code to the minimum. So hopefully the docs will also get a note about how to use the id property's properly

Thanks for the fix!

[stephen.friedrich]

Still, if there is only ever a single instance of a component, the definition is a better place for the id I think.
For example if I designed a custom modal warning window, it may come with specific CSS that expects a certain id. Why should the client of the window be bothered with that?