[PR4] JSONP throws uncaugth exception when url is wrong

[ASraniel]

This worked in PR3. When i load a store that uses a JSONP proxy that points to a non working url, this exception is thrown:

Uncaught TypeError: Cannot call method 'getJsonP' of undefined

the problem is now that i can't intercept this. Before, the load event of the store was triggered, that then told me that is was not successful. I tried to add a listener to the proxy exception event, but that didn't change anything. Here is the backtrace (using sencha-touch-all-debug.js).

Uncaught TypeError: Cannot call method 'getJsonP' of undefined sencha-touch-all-debug.js:23888
Ext.define.setException sencha-touch-all-debug.js:23888
Ext.define.processResponse sencha-touch-all-debug.js:23608
(anonymous function) sencha-touch-all-debug.js:23882
Ext.apply.callback sencha-touch-all-debug.js:5957
Ext.define.handleResponse sencha-touch-all-debug.js:9852
Ext.define.handleError sencha-touch-all-debug.js:9818
(anonymous function) sencha-touch-all-debug.js:1964

[Jamie Avins]

Thank you for the report.

[ASraniel]

Thank you for your fast answer. Do you need a simple testcase to reproduce? This bug is very important for my application, so anything i can do to help speed up the bugfix i would be happy to do.

[Jamie Avins]

That always helps us pin it down and be sure it's fixed.

[TommyMaintz]

This has been fixed and will be part of the next release. Try this override for now:

Ext.override('Ext.data.proxy.JsonP', {
    setException: function(operation, response) {
        operation.setException(operation.getRequest().getJsonP().errorType);
    }
});

[ASraniel]

Special thanks for this fix including the workaround Really increased the trust i have in sencha touch good job!

[ASraniel]

Ext.override seems to be deprecated and Ext.define should be used. I'm struggling with how that exactly works, currently i came up with this (not working):

Ext.define('Ext.data.proxy.JsonP2', {	override: 'Ext.data.proxy.JsonP',
    setException: function(operation, response) {
        operation.setException(operation.getRequest().getJsonP().errorType);
    }
});


Ext.define('Ext.data.proxy.JsonP', {
    requires: [
        'Ext.data.proxy.JsonP2'
    ]
});

I will post here if i manage to find a solution.

[ASraniel]

In the end i just changed the sencha touch javascript file, was quicker than figuring out how to override the function of an existing class.