Problem with onHistoryChange

[aflx]

Hi there,

I'm migrating from PR3 to PR4. Now I have a problem with the new history feature.
I'm not using any routes which causes a NPE if the history/url changes.

The application will trigger a change in the onHistoryChange-event here (in Ext.app.Application):

onHistoryChange: function(url) {
    this.dispatch(this.getRouter().recognize(url), false);
}

The problem is, that recognize() returns undefined, if the url is not found, which causes a NPE in the dispatch function because the first parameter (action) is null/undefined!

dispatch: function(action, addToHistory) {
      action = Ext.factory(action, Ext.app.Action);

      var profile    = this.getCurrentProfile(),
            profileNS  = profile ? profile.getNamespace() : undefined,
            controller = this.getController(action.getController(), profileNS);

      if (controller) {
            if (addToHistory !== false) {
                this.getHistory().add(action, true);
            }

            controller.execute(action);
      }
},

Can you please have a look at it? I think the NPE should be catched. Or do I have to define routes?

Best regards,
Alex

[Jamie Avins]

Absolutely, we'll do more rigorous checking there.

[edspencer]

Thanks for the report, this is already fixed in latest, will function correctly in the next release