Same ID Component Bug

[umr.ashrf]

I think what I found seems a PR4 bug but would like to confirm if it persist at your side too.

I created a panel under a view like this.

var video = Ext.create('Ext.Panel', {
    id : 'jwPlayerContainer',
    html : '<object type="application/x-shockwave-flash" id="jwplayer" name="jwplayer" data="jwplayer/player.swf" width="480" height="270" style="width: 1286px !important; height: 230px !important; "><param name="allowfullscreen" value="true"><param name="allowscriptaccess" value="always"><param name="flashvars" value="file=' + flashvars.file + '&amp;streamer=' + flashvars.streamer + '"></object>'
});

I remove all components and then add this to the view.

this.removeAll(true, true);
this.add(video);

My job is to resize the <object> based on its container so I use.

this.sizeMonitor = new Ext.util.SizeMonitor({
    element : video.getEl(),
    callback : this.onSizeChange,
    scope : this
});

My onResizeChange callback.

onSizeChange : function() {
    var jwPlayer = Ext.get('jwplayer');
    var jwPlayerContainer = Ext.get('jwPlayerContainer');
    
    if(jwPlayer && jwPlayerContainer) {
        console.log(jwPlayer.dom);
        console.log(jwPlayerContainer.dom);
        
        jwPlayer.setWidth(jwPlayerContainer.getWidth());
        jwPlayer.setHeight(jwPlayerContainer.getHeight());
    }
}

When user presses back button and comes again to that view the same panel with object element is added and new sizeMonitor is set. But this time the added panel and object element which was destroyed is returned and not the new one.

Is that a known bug?

[mitchellsimoens]

When you do this.add... are you recreating the panel?

[umr.ashrf]

Here's the function that is being called from outside the view. This function is called from other views.

addVideoPlayer : function(url, thumbnail) {    //split link into two parts
    var urlSplitted = url.match(/^(.*)\/([^\/]+)$/);
    
    var flashvars = {
        file : urlSplitted[2],
        streamer : urlSplitted[1]
    };
    flashvars = {
        file : 'live',
        streamer : 'rtmp://fms-live.xstream.dk/bb_live'
    };
    
    this.remove(this.jwplayer, true);
    
    this.jwplayer = Ext.create('Ext.Panel', {
        id : 'jwPlayerContainer',
        html : '<object type="application/x-shockwave-flash" id="jwplayer" name="jwplayer" data="jwplayer/player.swf" width="480" height="270" style="width: 1286px !important; height: 230px !important; "><param name="allowfullscreen" value="true"><param name="allowscriptaccess" value="always"><param name="flashvars" value="file=' + flashvars.file + '&amp;streamer=' + flashvars.streamer + '"></object>'
    });
    
    this.add(this.jwplayer);
    
    this.sizeMonitor = new Ext.util.SizeMonitor({
        element : this.jwplayer.getEl(),
        callback : this.onSizeChange,
        scope : this
    });
    
    this.onSizeChange();
}

[mitchellsimoens]

After removal, have you checked the ComponentManager to see if the id is gone?

Personally, I would only use id for debugging, not production code.

[umr.ashrf]

Ok how can I have access to

ComponentManager? By Ext.ComponentManager? It seems private utility class.

Also why won't you use id? The <object> tag is added to the container as text markup.

[mitchellsimoens]

You are just checking to see if the id was removed for debugging.

I don't use id as you get collisions. ComponentQuery is a much better solution, your app has a hierarchy and can resolve a component based on this.

[rdougan]

ComponentQuery is very flexible, however it has huge performance constraints, so we recommend you use id for unique components.

Please test your application using Beta 1. I know there were issues fixed with recreating components using an ID that was used before.

[umr.ashrf]

Here are my debugging results with PR4.

Ext.ComponentManager.get('jwPlayerContainer')
>Ext.apply.create.Class


Ext.ComponentManager.get('jwplayer')
undefined


Ext.ComponentQuery.query('object');
[]


Ext.ComponentQuery.query('object', Ext.ComponentManager.get('jwPlayerContainer'));
[]

[rdougan]

If you are creating DOM using the html configuration, you need to use Ext.get to get an instance of your element, as it is not a component.

Ext.get('jwplayer');

This will return an instance of Ext.dom.Element and you can work from there.

[umr.ashrf]

I tried with Sencha Touch 2 beta 1 and the bug is also there.

I can reproduce the bug.

1. Add a panel with html div id set to something.

html = '<div id="test-div-1"></div>';

2. After some time (using setInterval), add an Button to that div using renderTo property.
3. Remove the button component.
4. Try Ext.get('id'); There is a instance but not what we want.