Looks like we cannot reproduce this. Please provide another test case to reproduce this issue.
  1. #1
    Sencha User
    Join Date
    Jan 2012
    Posts
    37
    Vote Rating
    0
    amaccann is on a distinguished road

      0  

    Default PR4: Ext.Msg.alert error

    PR4: Ext.Msg.alert error


    Hey, thought I'd flag this one as it's appeared since PR3; if you accidentally pass in an undefined string into Ext.Msg.alert, it seems to cause the following error:

    Uncaught TypeError: Cannot call method 'replaceCls' of null

    I traced the problem back to a section of the code where I was calling this line.
    Ext.Msg.alert(result.data.header, result.data.message);

    when it was being called, result.data.header didn't exist, was undefined, and carried on. However, when I called Msg.alert again elsewhere in the code, I got the above error. Obviously the simple solution is "Don't pass in an undefined varible", but thought I'd flag this in any case

  2. #2
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    20
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    Sounds like something we should handle gracefully, thank you for the report.

    Sencha Inc

    Jamie Avins

    @jamieavins

  3. #3
    Sencha - Sencha Touch Dev Team rdougan's Avatar
    Join Date
    Oct 2008
    Posts
    1,158
    Vote Rating
    6
    rdougan will become famous soon enough

      0  

    Default


    Odd; I cannot reproduce this on PR4 or Beta 1. Could you test beta 1 or give a better testcase please?

    Thanks.
    Sencha Inc.
    Robert Dougan - @rdougan
    Sencha Touch 2 and Ext JS 4 Core Team Member, SASS/Theming Wizard.

  4. #4
    Sencha User
    Join Date
    Jan 2012
    Posts
    37
    Vote Rating
    0
    amaccann is on a distinguished road

      0  

    Default


    Quote Originally Posted by rdougan View Post
    Odd; I cannot reproduce this on PR4 or Beta 1. Could you test beta 1 or give a better testcase please?

    Thanks.
    Can't check on Beta, as there are other issues with that version preventing me, but I can certainly provide the offending code that was causing the issue, if that's any help to you

    Code:
        Ext.util.JSONP.request({
          url: window.serverPath + '/api/bets/create',
          callbackKey: 'callback',
          params: {
            user_credentials: window.user_credentials, 
            order: selectedOrder,
            components: Ext.encode(this.components),
          },
          callback: function (result) {
    
    
               app.unmask(this.getBetslipoverlay());
            
            miscData.current_balance -= form.getValues().amount;
            controller.getAmountField().reset(); //Reset amount text input
    
    
            if (result.data.description != undefined) { // We have error message back
              Ext.Msg.alert(result.data.header, result.data.description);
            } else { // Success
              
              controller.components = null;
              controller.components = [];
    
    
              Ext.Msg.alert("", "Your order has been placed!");
              //Ext.Msg.alert(result.data.header, result.data.message);
    So in the above code, if result.data.header (not sure about data.message) was coming back non-existent/ undefined, while the alert would still get called, subsequent Msg.alert calls were throwing the error mentioned in the original post.

Thread Participants: 2