Can't define a custom association (ST2-B3)

[Zyphrax]

In our project we would like to create a custom association class that works a little bit different than the belongsTo association. Unfortunately this seemingly old piece of code in Ext.data.association is giving me a headache:

statics: {
        create: function(association) {
            if (!association.isAssociation) {
                if (Ext.isString(association)) {
                    association = {
                        type: association
                    };
                }

                switch (association.type) {
                    case 'belongsTo':
                        return Ext.create('Ext.data.association.BelongsTo', association);
                    case 'hasMany':
                        return Ext.create('Ext.data.association.HasMany', association);
                    case 'hasOne':
                        return Ext.create('Ext.data.association.HasOne', association);
                    default:
                        //<debug>
                        Ext.Logger.error('Unknown Association type: "' + association.type + '"');
                        //</debug>
                }
            }

            return association;
        }
    }

Could you change default: to Ext.create(association.type)?
I think that the switch is somewhat nasty

[mitchellsimoens]

I think instead of the switch it could try to resolve the association class name based ont he type being passed in and the alias of the associations themselves.

[TommyMaintz]

Alright, this has been fixed for the next release.

The only thing that I think you might run into is the fact that reading in associated data in Model.js is checking for the type on the association. If you make a custom one, this code would not be triggered.

[Zyphrax]

Thanks for the fix!

[bparker]

Any chance this could get applied to the main ExtJS 4.1 code as well?

[mrroohian]

I fixed the problem with this patch. Waiting for the new release though.

    statics: {
        
        create: function(association){
            if (Ext.isString(association)) {
                association = {
                    type: association
                };
            }


            switch (association.type) {
                case 'belongsTo':
                    return new Ext.data.association.BelongsTo(association);
                case 'hasMany':
                    return new Ext.data.association.HasMany(association);
                case 'hasOne':
                    return new Ext.data.association.HasOne(association);
                




                default:
                    // I hope this works with the fix in the new version
                    return Ext.createByAlias('association.' + association.type.toLowerCase(), association);
            }
            return association;
        }
    },