Issue when hasOne association is null

[Basta]

I have the following data models:

Ext.regModel('Result', {
    associations: [
        {
            type: 'hasOne',
            model: 'Score',
            associationKey: 'halfTime',
            getterName: 'getHalfTime'
        },
        {
            type: 'hasOne',
            model: 'Score',
            associationKey: 'fullTime',
            getterName: 'getFullTime'
        },
        {
            type: 'hasOne',
            model: 'Score',
            associationKey: 'overTime',
            getterName: 'getOverTime',
            autoLoad: false
        },
        {
            type: 'hasOne',
            model: 'Score',
            associationKey: 'afterPenalties',
            getterName: 'getAfterPenalties',
            autoLoad: false
        }    
    ]
});

Ext.regModel('Score', {
    fields: [
        {name : 'home', type : 'int', optional: true, defaultValue: null}, 
        {name : 'away', type : 'int', optional: true, defaultValue: null}
    ],
    belongsTo: 'Result'
});

Now the problem is that some of the associations can be NULL in the received JSON data. Example:

"result":{
   "halfTime":{
      "home":3,
      "away":0
   },
   "fullTime":{
      "home":4,
      "away":1
   },
   "overTime":null,
   "afterPenalties":null
}

In this case if I try to access the data like

var score = result.getFullTime();

It results in the error:

Uncaught TypeError: Cannot call method 'indexOf' of undefined

If I remove the 'overTime' and 'afterPenalties' association it all works fine with the above data. I don't understand how I should add 'optional' associations.

[mitchellsimoens]

First suggestion is you shouldn't use Ext.regModel in ST2 anymore, instead you should use Ext.define:

Ext.define('Result', {
    extend : 'Ext.data.Model',

    config : {
        hasOne : [
            {
                associatedModel : 'Score',
                associationKey  : 'halfTime',
                getterName      : 'getHalfTime',
                associatedName  : 'halfTime'
            },
            {
                associatedModel : 'Score',
                associationKey  : 'fullTime',
                getterName      : 'getFullTime',
                associatedName  : 'fullTime' },
            {
                associatedModel : 'Score',
                associationKey  : 'overTime',
                getterName      : 'getOverTime',
                associatedName  : 'overTime'
            },
            {
                associatedModel : 'Score',
                associationKey  : 'afterPenalties',
                getterName      : 'getAfterPenalties',
                associatedName  : 'afterPenalties'
            }
        ]
    }
});

Ext.define('Score', {
    extend : 'Ext.data.Model',

    config : {
        fields: [
            {name : 'home', type : 'int', optional: true, defaultValue: null},
            {name : 'away', type : 'int', optional: true, defaultValue: null}
        ],
        belongsTo: 'Result'
    }
});

Running this against our latest code it only errors out when I execute getOverTime or getAfterPenalties because I don't have a url specified in a proxy on the Score model as it is trying to load the model because data isn't present.

[Basta]

Thank you for your response. It appears that if you use a hasOne association the data really has to have a related record and can't have null. I've ended up using a hasMany association, which can accept 0 or more related record. I can then look at result.overTime().count to see if it has a overTime result or not. I would expect that similar would be possible with a hasOne association but can't get that working. For now I can live with the above.

[sfpc2770]

So is there a way to avoid this error when it is a valid scenario? Some way to not have the proxy attempt to load the data if the data truly isn't there?

[clarkstachio]

I too have the same issue. I'm using a rest proxy, and if my associated object is null, it will attempt to autoload the data via the proxy. This is an issue of course, because my business model allows in many places for null hasOne relationships, where the data doesn't exist.

To work around this for now, I am returning an empty array in the json instead of null. The model then does not attempt to autoload because it has a dummy object already loaded for the association.

Has anyone found a valid solutions to this?

[coolfish]

I haven't yet. I am encountering a similar problem now, except the association is basically loading the first available model it finds (I added a few checks in the sencha touch 2 code to prevent it from erroring out if the referred object is null or undefined, but this seems to have introduced this new bug for me.) I'm not sure if the Sencha team will get around to this, but I think a hasOne should be able to be null.