1. #1
    Sencha User
    Join Date
    Jan 2011
    Location
    SF Bay Area, CA
    Posts
    5
    Vote Rating
    1
    JonathanEF is on a distinguished road

      0  

    Default Ext.form.field.ComboBox initComponent is missing a default if( !me.name )?

    Ext.form.field.ComboBox initComponent is missing a default if( !me.name )?


    I have found that in IE7, if you don't supply a name config option, the combobox field will open its menu in the top left of the page. Just to make it clear, I have not observed this issue in IE8, IE9, FireFox, or Chrome (I haven't tried the IE10 beta).

    I have no idea why the name config option fixes this.

    So I looked at the initComponent function for the combobox, and I noticed that the only part it checks for a me.name and then provides a default value is if the combobox is transforming an existing component (I am guessing it is so you can swap displayfields into comboboxes and vice versa).

    So perhaps after the transform block an "else if" should be added to make it look like this:
    Code:
    if (transform) {
      transformSelect = Ext.getDom(transform);
      if (transformSelect) {
        store = Ext.Array.map(Ext.Array.form(transformSelect.option), function(option) {
          return [option.value, option.text];
        });
        if (!me.name) {
          me.name = transformSelect.name;
        }
        if (!('value' in me)) {
          me.value = transformSelect.value;
        }
      }
    }
    //here is the added portion
    else if (!me.name) {
      me.name = me.id || (me.id = Ext.id());
    }
    Does this seem to be the right solution (instead of just supplying unused name options which could one day get me into trouble when a BS name ends up in an ajax fetch) or am I blowing smoke?

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    37,330
    Vote Rating
    847
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    What Ext JS 4 version are you seeing the list being shown not aligned correctly?
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  3. #3
    Sencha User
    Join Date
    Jan 2011
    Location
    SF Bay Area, CA
    Posts
    5
    Vote Rating
    1
    JonathanEF is on a distinguished road

      0  

    Default


    Core: 4.0.7
    ExtJS: 4.0.7

Thread Participants: 1