Ext Direct no callback if server returned junk

[yozik04]

Version 4.1-rc1
File: Ext.direct.RemotingProvider

    onData: function(options, success, response){
        var me = this,
            i = 0,
            len,
            events,
            event,
            transaction,
            transactions;

        if (success) {
            events = me.createEvents(response);
            for (len = events.length; i < len; ++i) {
                event = events[i];
                transaction = me.getTransaction(event);
                me.fireEvent('data', me, event);
                if (transaction) {
                    me.runCallback(transaction, event, true);
                    Ext.direct.Manager.removeTransaction(transaction);
                }
            }
        } else {

transaction variable is null when server returned junk.
That is why no callback is called.

The same result if server returned empty text. Javascript error appears, no callback received.

[mitchellsimoens]

Thanks for the report.

[evant]

For a direct request to be processed, it needs to return a valid set of JSON data, otherwise we can never identify which transactions we need to process, this is especially important when we consider request batching.

The provider will fire a "data" event each time it receives data. In the cases where it can't parse the event, it will send an exception object as the parameter to the data event.

[Lukappa]

I found a way to do it... adding a listener (exception) on direct and "forcing" to execute the code in the callback:

the main app code:

Ext.direct.Manager.addProvider(Ext.app.REMOTING_API);
Ext.direct.Manager.on('exception', function(opts) {
        opts.xhr.request.options.transaction.callback(null, null);
    }, this);

....
the direct request code (it could be in some controller):

Ext.app.myClass.myMethod(params, function(provider, response){
    if(response == null) {
          alert("Server error");
    } else {
          console.log(response.result)
         //your code
    }
});

....
the server side code (example of error)

<?php
public function myMethod($params) { 
    return 5/0; //<--- this will produce a "division by zero" php Warning
}
//...

So in this way I found a simple 'trick' to handle some problem about server system, php notice & warning and so on...

I'm not a extjs guru =) and I'd like to know what sencha devs think about it, thank you.