[FIXED][4.1 RC1] layouts problems in chrome18 (fixed in RC3)

[Diavololt]

OPEN
Ext version tested:

• 4.1 B3
• 4.1 RC1

Browser versions tested against:

• Chrome 18

Problem description:

extjs/examples/layout/accordion.html

After some clicks on accordion items or resize west region, the panel is broken. See a picture.


P.S. CLEAN browser cache first.


extjs_panel_bug.jpg

P.S2: After chrome 18 update my components like accordion, tabpanel (inside Ext.panel.Panel), fill blue after clicks on items or add/remove some tabs.

static/extjs/examples/layout/border.html
extjs_panel_bug2.jpg

[tvanzoelen]

Fix in post no. 22 by rhapsodyv http://www.sencha.com/forum/showthre...me-18-19/page3 seems to have a little effect but does not fix all issues.

Ext.override(Ext.layout.ContextItem, {
    setHeight: function (height, dirty ) {
        var me = this,
            comp = me.target,
            frameBody, frameInfo, padding;

        if(isNaN(height)){
            return;
        }

        if (height < 0) {
            height = 0;
        }
        if (!me.wrapsComponent) {
            if (!me.setProp('height', height, dirty)) {
                return NaN;
            }
        } else {
            height = Ext.Number.constrain(height, comp.minHeight || 0, comp.maxHeight);
            if (!me.setProp('height', height, dirty)) {
                return NaN;
            }

            frameBody = me.frameBodyContext;
            if (frameBody){
                frameInfo = me.getFrameInfo();
                frameBody.setHeight(height - frameInfo.height, dirty);
            }
        }

        return height;
    },

    
    setWidth: function (width, dirty ) {
        var me = this,
            comp = me.target,
            frameBody, frameInfo, padding;


        if(isNaN(width)){
            return;
        }
        
        if (width < 0) {
            width = 0;
        }
        if (!me.wrapsComponent) {
            if (!me.setProp('width', width, dirty)) {
                return NaN;
            }
        } else {
            width = Ext.Number.constrain(width, comp.minWidth || 0, comp.maxWidth);
            if (!me.setProp('width', width, dirty)) {
                return NaN;
            }

            
            frameBody = me.frameBodyContext;
            if (frameBody) {
                frameInfo = me.getFrameInfo();
                frameBody.setWidth(width - frameInfo.width, dirty);
            }

            
        }

        return width;
    }
});

[Diavololt]

Thanks for quick reply and solution. It seems, with this override, now working fine.

[Animal]

So, I think I've tracked it down to a V8 bug which I've reported here: http://code.google.com/p/v8/issues/detail?id=2056

We can work around this - I'll have an update in Ext.Number.constrain soon.

I didn't want to just put those patches in without finding out what was happening.

[rhapsodyv]

Crazy!! Math.max(NaN, 0) === 0 in Chrome!! :-p

[JanVenekamp]

In my ext-fixes.js:

/*
 * Chrome 18+ Math.max/min(NaN, 0) === 0 BUG
 *
 * http://www.sencha.com/forum/showthread.php?192517-OPEN-4.1-RC1-layouts-problems-in-chrome18&p=771679&viewfull=1#post771679
 */
Ext.Number.constrain = function(number, min, max) {
    number = parseFloat(number);

    if (isNaN(number)) {
        return NaN;
    }
    if (!isNaN(min)) {
        number = Math.max(number, min);
    }
    if (!isNaN(max)) {
        number = Math.min(number, max);
    }
    return number;
};

[karlsnyder0]

In my ext-fixes.js:

/*
 * Chrome 18+ Math.max/min(NaN, 0) === 0 BUG
 *
 * http://www.sencha.com/forum/showthread.php?192517-OPEN-4.1-RC1-layouts-problems-in-chrome18&p=771679&viewfull=1#post771679
 */
Ext.Number.constrain = function(number, min, max) {
    number = parseFloat(number);

    if (isNaN(number)) {
        return NaN;
    }
    if (!isNaN(min)) {
        number = Math.max(number, min);
    }
    if (!isNaN(max)) {
        number = Math.min(number, max);
    }
    return number;
};

And all this time I thought it was something I did.

This workaround appears to work for me. Thanks! And thank you Animal for reporting to Google their goof.

[ludoo]

Strange fix but it fixes all my troubles about layout resizing on toolbar and panel's body in chrome 18 too with 4.1RC2.

Thanks !

[Diavololt]

In 4.1.0 RC3 this problem has been fixed. Thanks!