Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Sencha User
    Join Date
    Nov 2011
    Posts
    10
    Vote Rating
    0
    slrobertson1 is on a distinguished road

      0  

    Default ST 2.0.1RC - Changed signature of Ext.field.Slider events

    ST 2.0.1RC - Changed signature of Ext.field.Slider events


    I noticed that the parameters signature of events fired by Ext.field.Slider in 2.0.1RC have changed and wondered if this was intentional or a bug. The new event handlers look like this:

    Code:
    onSliderChange: function() {
        this.fireEvent('change', [this, Array.prototype.slice.call(arguments)]);
    }
    The old signatures looked like this:

    Code:
    onSliderChange: function(slider, thumb, newValue, oldValue) {
        this.fireEvent('change', this, slider, thumb, newValue, oldValue);
    }
    In order to minimize the impact on an existing project that I am upgrading to 2.0.1RC, I have implemented overrides for these events. My question is, are the new change, drag, dragstart and dragend event signatures supposed to look like "[this, Array.prototype.slice.call(arguments)])"?

    Thanks,
    Scott

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    St. Louis, MO
    Posts
    33,624
    Vote Rating
    434
    mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of

      0  

    Default


    I can see what this change is doing but it's not proper so I'm opening a ticket for this. Thank you!
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    http://www.JSONPLint.com - Source to lint your JSONP!

    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is almost in print!

    When posting code, please use BBCode's CODE tags.

  3. #3
    Ext JS Premium Member Brendan Carroll's Avatar
    Join Date
    May 2007
    Location
    Balmer, MD.
    Posts
    139
    Vote Rating
    1
    Brendan Carroll is on a distinguished road

      0  

    Default


    Experiencing the same confusion on the new signature. +1
    -BC ...

  4. #4
    Sencha Premium Member Martin1982's Avatar
    Join Date
    Aug 2011
    Location
    The Netherlands
    Posts
    109
    Vote Rating
    0
    Martin1982 is on a distinguished road

      0  

    Default


    Bumped into this one as well today, +1 again
    It can be worked around though by catching the arguments, but it seems like it's unintended
    Allround web developer, conference organiser and speaker.

  5. #5
    Sencha - Sencha Touch Dev Team Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,652
    Vote Rating
    14
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    This was mentioned several times in the changelog. The original signature was the mistake, not the new one.

    Sencha Inc

    Jamie Avins

    @jamieavins

Tags for this Thread