BUG - [Ext 4.1 RC2] Ext.ux.grid.FiltersFeature removes dynamically added filters

[xsba]

REQUIRED INFORMATION

Ext version tested:

• Ext 4.1 RC2

Browser versions tested against:

• IE8
• FF11 (firebug 1.9.1 installed)

Description:

• if filters was added dynamically before the menu was shown, Ext.ux.grid.FiltersFeature createFilters() method will remove all and will try to re-create filters from the config

Steps to reproduce the problem:

• create FiltersFeature with empty filters
• add filters dynamically with addFilter() method
• open headers menu, it will be without filters

The result that was expected:

• headers menu should contain Filters section

The result that occurs instead:

• headers menu doesn't contain Filters section

Test Case:

     
    this.filters = Ext.create('Ext.ux.grid.FiltersFeature', {       
        updateBuffer : 500,
        filters      : []
     });

     this.filters.addFilter({
        type      : 'string',
        dataIndex : 'id'
     });

HELPFUL INFORMATION

Debugging already done:

• Ext.ux.grid.FiltersFeature createFilters() method removes all existing filters and tries to re-create filters from config or grid columns

Possible fix:

• not provided

Additional CSS used:

• only default ext-all.css

Operating System:

• Win7

[mitchellsimoens]

Thanks for the report.

[xsba]

At the release notes to Ext 4.1 this one is marked as fixed, but unfortunately the fix causes new bug.

Steps to reproduce:

1. Create a grid.
2. Reconfigure grid with new columns: reconfigure( [Ext.data.Store store], [Object[] columns] )
3. try to use addFilter.
4. filters menu will not be created.

The problem is:

FiltersFeature.createFilters: function() { 
257: Ext.Array.each(grid.columns, function (column) {

FiltersFeature.addFilter : function (config) {
591:columns = me.getGridPanel().columns,

line 257 and 591 - it uses grid.columns, but columns can be a config object

During Grid initialization the columns are overrided with new value:

me.columns = me.headerCt.items.items;

but not after reconfigure method, so createFilters will skip new columns

[rpieter]

I was able to work around this by modifying the FilterFeature-plugin (4.1) on line 312.
I changed

if (!menuItem || menuItem.isDestroyed) {

into

if (!menuItem || menuItem.isDestroyed || menu.getComponent('filters') === undefined) {

and the item is now shown properly every time, even after rebuilding/reconfiguring the grid.