Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-5967 in a recent build.
  1. #1
    Touch Premium Member
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    1,564
    Vote Rating
    343
    LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of LesJ has much to be proud of

      0  

    Default ElementLoader - inconsistent API (?)

    ElementLoader - inconsistent API (?)


    See the line that I commented out. Now non-false return value indicates success. I think this change would be consistent with the way event handlers work.

    Code:
    Ext.define('Ext.ElementLoader', {
        ...
        onComplete: function(options, success, response) {
            var me = this,
                active = me.active,
                scope = active.scope,
                renderer = me.getRenderer(active.renderer);
    
    
            if (success) {     
                success = renderer.call(me, me, response, active);
            }
    
            //  if (success) {
            if (success !== false) {            
                Ext.callback(active.success, scope, [me, response, options]);
                me.fireEvent('load', me, response, options);
            } else {
                Ext.callback(active.failure, scope, [me, response, options]);
                me.fireEvent('exception', me, response, options);
            }
            Ext.callback(active.callback, scope, [me, success, response, options]);
    
            if (active.mask) {
                me.removeMask();
            }
    
            delete me.active;
        },
        ....

  2. #2
    Sencha - Support Team scottmartin's Avatar
    Join Date
    Jul 2010
    Location
    Houston, Tx
    Posts
    9,229
    Vote Rating
    484
    scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future

      0  

    Default


    Thanks for the report.

    Scott.

Thread Participants: 1