-
16 Apr 2012 10:51 AM #1
ElementLoader - inconsistent API (?)
ElementLoader - inconsistent API (?)
See the line that I commented out. Now non-false return value indicates success. I think this change would be consistent with the way event handlers work.
Code:Ext.define('Ext.ElementLoader', { ... onComplete: function(options, success, response) { var me = this, active = me.active, scope = active.scope, renderer = me.getRenderer(active.renderer); if (success) { success = renderer.call(me, me, response, active); } // if (success) { if (success !== false) { Ext.callback(active.success, scope, [me, response, options]); me.fireEvent('load', me, response, options); } else { Ext.callback(active.failure, scope, [me, response, options]); me.fireEvent('exception', me, response, options); } Ext.callback(active.callback, scope, [me, success, response, options]); if (active.mask) { me.removeMask(); } delete me.active; }, ....
-
17 Apr 2012 4:39 PM #2
Thanks for the report.
Scott.
Success! Looks like we've fixed this one. According to our records the fix was applied for
EXTJSIV-5967
in
4.1.0 Sprint 13 (GA).


Reply With Quote