[4.1.0] Ext.view.AbstractView problem with indexOf

[christophe.geiser]

Hi all,
indexOf in AbstractView is creating errors under some scenario.
We should have

    
indexOf: function(node) {   node = this.getNode(node);
  // test for existence of node
   if(!Ext.isDefined(node)) {return -1}
  // end addition
   if (Ext.isNumber(node.viewIndex)) {
       return node.viewIndex;
    }
  return this.all.indexOf(node);
}

or something equivalent for avoiding the error I get: Uncaught TypeError: Cannot read property 'viewIndex' of null

Cheers,
C.

[scottmartin]

Thank you for the report!

Regards,
Scott

[silcreval]

Also seeing this. Seems to be associated with a grid.

In my case node is null, and returning -1 after a test for null just pushes the problem further down the line.

[jclark42796]

I'm trying to determine if this is a related problem. I have a grid store that if I remove the store's content, store.removeAll(), and then repopulate the store via add() I get

"node is null" where this.getNode(node) returns null.

    indexOf: function(node) {
        node = this.getNode(node);
        if (Ext.isNumber(node.viewIndex)) {  // node is null here
            return node.viewIndex;
        }
        return this.all.indexOf(node);
    },

I have no problems the first time the store is loaded.

stack:

indexOf
setPosition
onViewRefresh()
fire()
continueFireEvent
fireEvent(eventName="refresh")
refresh()
callParent
refresh
callParent
refresh
onAdd
callAprent
onAdd
fire
continueFireEvent(eventName="add"...)
insert(index=0...)
addSorted
add
.....

Thanks,
Jim

[aaquibnawaz]

Hi can anyone help i am new to extjs and i am facing the same error while removing the store contents using store.removeAll() and reinserting using store.insert()

TypeError: A is null [Break On This Error]
if(Ext.isNumber(A.viewIndex)){return A.viewIndex}