Wrong getEditor() call in RowModel.

[skullbooks]

REQUIRED INFORMATIONExt version tested:

• Ext 4.1.0 RC3

Browser versions tested against:

• Chrome 18

Description:
The Ext.selection.RowModel#onEditorTab calles getEditor without parameter. As in the documentation in Ext.grid.colum.Column#getEditor there should be the record and the default field.

Test Case:

In our own column i need the record for my column editor and since ExtJS 4.1.0 RC2 i don't get the editor on TABing into the column editor.

HELPFUL INFORMATION

Debugging already done:

• Wrong getEditor() call in RowModel.

Possible fix:

• think the solution should be a while like this
  

• while(position && !view.headerCt.getHeaderAtIndex(position.column).getEditor(record, header));

Additional CSS used:

• only default ext-all.css

[scottmartin]

Have you tried 4.1 GA (final)?

Regards,
Scott.

[skullbooks]

now i did it, but it's still not working - well

Ext.selection.RowModel#onEditorTab is caling getEditor without any parameter so the but for me still has to be there

[skullbooks]

will this be a bug in next time or can't i assume the parameter for getEditor in my own column as they are documented?

[yyogev]

Have you tried 4.1 GA (final)?

Regards,
Scott.

This code is still not fixed in ExtJS 4.1.0:
(ext-all-debug.js, line 84254, or rowModel.js line 442)

[skullbooks]

also not fixed in EXT 4.1.1 RC2

seems to me like sencha sees no need to fix that

maybe it's helpful to write a line where this makes problems:

if you write your own colum with a special editor that needs the record, i see the only way in implementing the getEditor in the column and give the selected record to the editor instance.
but in the case you edit the grid by switching columns with TAB, you don't get the record. so you cant update the editor that is depending on some current values of the record.

[yyogev]

if (record == undefined)
    record = ext.getCmp("my_grid").plugins[0].getActiveRecord();