[4.1.0] Window is not closed on Esc

**Daniil** · 8 May 2012 9:53 AM

Hi,

Apologize if it has been reported before, I was unable to find.

Also I assume it is a known bug. But I decided to report.

REQUIRED INFORMATION

Ext version tested:

Ext 4.1.0

Browser versions tested against:

Any

DOCTYPE tested against:

Any

Description:

A Window is not closed on Esc according to

http://docs.sencha.com/ext-js/4-1/#!/api/Ext.window.Window-cfg-onEsc

Steps to reproduce the problem:

Focus any Window and press Esc.

The result that was expected:

The window is closed.

The result that occurs instead:

The Window is not closed.

Test Case:

Please see the steps to reproduce.

HELPFUL INFORMATION

Debugging already done:

The problem lies within the Window afterRender function. Its keyMap is always disabled.

Window afterRender

Code:

afterRender: function() {
    var me = this,
        keyMap;

    me.callParent();

    // Initialize
    if (me.maximized) {
        me.maximized = false;
        me.maximize();
    }

    if (me.closable) {
        keyMap = me.getKeyMap();
        keyMap.on(27, me.onEsc, me);

        //if (hidden) { ? would be consistent w/before/afterShow...
            keyMap.disable();
        //}
    }
}

Possible fix:

Workaround. I just enable the keyMap for now.
Code:
```
win.getKeyMap().enable();
```

**Daniil** · 15 Jun 2012 1:49 AM

Dear ExtJS team,

Could someone have a chance to look at the problem?

**Phil Guerrant** · 15 Jun 2012 6:03 AM

Can you provide a test case please? The following works fine for me:

Code:

Ext.onReady(function() {
    Ext.widget({
        xtype: 'window',
        height: 100,
        width: 100,
        title: 'hi'
    }).show();
});

When I press the escape key the window closes as expected.

**Daniil** · 15 Jun 2012 6:11 AM

Weird, it is really not reproducible with your test case.

But I am able to reproduce with this one.

Code:

Ext.onReady(function () {
    Ext.create("Ext.window.Window", {
        height   : 100,
        width    : 200,
        hidden   : false,
        html     : "Press Esc",
        renderTo : Ext.getBody()                
    });
});

It is reproducible with 4.1.1 rc2 as well.

**Animal** · 15 Jun 2012 9:30 AM

It's enabled on show.

Must never explicitly go through show if you use renderTo.

**Animal** · 15 Jun 2012 9:34 AM

Uncomment that test. And make it "if (me.hidden) {"

It only needs to disable it if it's hidden.

**Animal** · 26 Jun 2012 9:31 PM

The act of rendering does not focus a Component.

It's the show process, and resulting toFront process which does that for a Window.

The solution is to use the code that Phil posted. Call show, and the Window will autoRender and focus.

**Daniil** · 27 Jun 2012 12:59 AM

Hi,

Ok, it's not auto-focused. But a user can focus that Window manually and expect it will be closed on Esc. No?

**Animal** · 27 Jun 2012 1:54 AM

Yes, if you focus it, then it's KeyMap will receive key events, and listen for ESC.

You should not use renderTo for Windows. They autoRender just in time when you first show them.

**Daniil** · 27 Jun 2012 4:14 AM

Thanks for the advice.

But will it be rendered in Ext.getBody() all the time?

What about if a developer would like to render the Window into a <form> which is within the <body>? To cause the Window input elements to be automatically submitted.

[4.1.0] Window is not closed on Esc

Thread Tools

Search Thread

Display

[4.1.0] Window is not closed on Esc

[4.1.0] Window is not closed on Esc