Success! Looks like we've fixed this one. According to our records the fix was applied for EXTGWT-2165 in 3.0.1.
  1. #1
    Ext GWT Premium Member dardison's Avatar
    Join Date
    Apr 2008
    Location
    Buenos Aires, Argentina
    Posts
    174
    Vote Rating
    1
    dardison is on a distinguished road

      0  

    Default Could we have a getter for EditorConverterAdapter converter?

    Could we have a getter for EditorConverterAdapter converter?


    Hi guys,

    In the EditorConverterAdapter there is no getter for:

    Code:
    private Converter<T, U> converter;
    In the context of an EditorVisitor for example it would be very useful to have that getter in order to provide the T value from the U value.
    I know I could get the T value if I flush the editor, but inside the visitor I don't want to do that.

    Regards,
    Daniel

  2. #2
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Interesting idea, but it comes with a caveat - how is the subeditor wrapped by the adapter supposed to know to pass the value out to the converter? If I am using the Converter to turn a String into a Date and back again for a DateField, your idea makes sense since DateField actually has a getValue() method, but what about cases like String<=>Person and a Editor<Person> - how can the value of that subeditor be read out without flushing it?

    If we built ConverterEditorAdapter to _only_ work with LeafValueEditors, this might be possible, but this would also be constricting. A specialized subclass could be written that can only handle LeafValueEditors, and so could call LeafValueEditor.getValue(), pass the value through the Converter, and return it.

    Moving this to Discussion for now, pending further comments, as I don't think this even can be implemented.

  3. #3
    Ext GWT Premium Member dardison's Avatar
    Join Date
    Apr 2008
    Location
    Buenos Aires, Argentina
    Posts
    174
    Vote Rating
    1
    dardison is on a distinguished road

      0  

    Default


    I'm not asking you take care of anything, I 'm just asking if you could provide a getter, don't see the problem.
    At least could you provide a protected getter so we could subclassing the Converter?

  4. #4
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Right, got it - I had understood this to be a change in how getValue worked (i.e. the getter, using the converter) as opposed to a new getter for the Converter instance.

    Moving this back to bugs and filing it as a reasonable change to make.

    In the meantime, JSNI can be used to get the converter instance from the private field, either in your EditorVisitor or from within a subclass.

  5. #5
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Committed into SVN, will be available in the next release.

Thread Participants: 1