boolean field never set as modified when set with a boolean value

[dougi]

Hi,

i use extjs 4.1 commercial

i noticed something weird with boolean field.
the field is set as modified when its value is set with a string and not a boolean value. quite unexpected.

here is how it is declared:
{ name:'ready', type:'boolean', defaultValue: false, convert: null }

and the behavior i notice.
record.set('ready', true)
record.isModified('ready') => false

record.set('ready', 'true')
record.isModified('ready') => true

is that a bug or my mistake ?

Thanks

[evant]

It depends, how is the record constructed?

[dougi]

here is my model declaration:

Ext.define('QeApp.model.Version', {    extend: 'Ext.data.Model',
    
    fields: [
        { name:'id', type:'int' },
        { name:'type', type:'string' },
        { name:'ready', type:'boolean', defaultValue: false, convert: null } /* Boolean set as modified when set with string value only */
    ],
    associations: [...]
});

the ready field is also correctly set as boolean in the flow of data loaded from the server.

Thanks again

[evant]

I can't reproduce it. I ran this against 4.1.0, it logs true for both records:

Ext.define('Foo', {
    extend: 'Ext.data.Model',

    fields: [{
        name: 'id',
        type: 'int'
    }, {
        name: 'type',
        type: 'string'
    }, {
        name: 'ready',
        type: 'boolean',
        defaultValue: false,
        convert: null
    }]
});

Ext.onReady(function(){
    var rec1 = new Foo({
        id: 1,
        type: 'type1',
        ready: false
    });
    rec1.set('ready', true);
    console.log(rec1.isModified('ready'));
    
    var rec2 = new Foo({
        id: 2,
        type: 'type2',
        ready: true
    });
    rec2.set('ready', false);
    console.log(rec2.isModified('ready'));
});

[dougi]

ok, you are right, sorry for the post. I should have make this simple test myself. Thanks for the example. It still don't work in my case...i will find it