Ext JS 4.1.1 RC2 - Ext.layout.container.BoxOverflow.Menu.destroy throws Exception

[campersau1]

Ext.layout.container.BoxOverflow.Menu.destroy Method throws Exception because me.menuTrigger is undefined.

The Exception: Uncaught TypeError: Cannot call method 'getItemId' of undefined

Here is the call Stack:

trigger is undefined
menu.jpgAbstractMixedCollection.jpggetComponentId.jpg


FIX:

    destroy: function() {
        var trigger = this.menuTrigger; // <-- menuTrigger can be undefined

        if (trigger && !this.layout.owner.items.contains(trigger)) { // fix for this bug
            // Ensure we delete the ownerCt if it's not in the items
            // so we don't get spurious container remove warnings.
            delete trigger.ownerCt;
        }
        Ext.destroy(this.menu, trigger);
    }

The destroy Method of Ext.layout.container.BoxOverflow.Menu.destroy in Ext 4.1.1 RC1 looked a bit simpler:

    destroy: function() {
        Ext.destroy(this.menu, this.menuTrigger);
    }

Sadly I have no test case at the moment...

[evant]

Is this is you destroy before/after the overflow has happened?

[campersau1]

Yes that caused this error!

The menu was inside a tab which was never activated.
If I activate the tab and then destroy the hole tabpanel then it worked without throwing the exception.

[evant]

That's odd. Since it calls Ext.destroy() it checks if the object isn't null first. Will have to check it out.

[campersau1]

In the pictures you can see that the menu is distroyed via Ext.destroy.
The Ext.destroy Method then calls the menu.destroy method, which in Ext 4.1.1 RC2 looks like this:

    destroy: function() {
        var trigger = this.menuTrigger; // <-- menuTrigger can be undefined

        if (trigger && !this.layout.owner.items.contains(trigger)) { // fix for this bug
            // Ensure we delete the ownerCt if it's not in the items
            // so we don't get spurious container remove warnings.
            delete trigger.ownerCt;
        }
        Ext.destroy(this.menu, trigger);
    }

[campersau1]

Looks like this is fixed in 4.1.1!