Success! Looks like we've fixed this one. According to our records the fix was applied for TOUCH-3036 in a recent build.
  1. #1
    Sencha Premium Member
    Join Date
    Feb 2012
    Posts
    15
    Vote Rating
    2
    cbobo is on a distinguished road

      1  

    Exclamation v2.0.1.1 data/Writer.js getRecordData() should be passing field.config to writeDate()

    v2.0.1.1 data/Writer.js getRecordData() should be passing field.config to writeDate()


    The date is always written as timestamp because field.dateFormat doesn't exist.

    writeDate: function(field, date) {
    var dateFormat = field.dateFormat || 'timestamp';


    In v2.0.1 The fieldConfig was cached as fieldConfig and passed as the first parameter to writeDate()
    Line 137: value = this.writeDate(fieldConfig, value);

    In v2.0.1.1 The field itself is passed to writeDate() and the field doesn't have a dateFormat property.
    Line 136: value = this.writeDate(field, value);


    I suggest renaming the first writeDate parameter to fieldConfig.
    Also, please write a unit test for this. Such a simple test to write.

    Thanks,
    Bobo

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    36,754
    Vote Rating
    827
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    Thanks for the report.
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  3. #3
    Sencha User
    Join Date
    Mar 2007
    Location
    Haarlem, Netherlands
    Posts
    1,243
    Vote Rating
    10
    TommyMaintz will become famous soon enough TommyMaintz will become famous soon enough

      0  

    Default


    Hmm, I don't understand how this made it into the build. The code in the current repository is correct and the unit tests are passing for this method. Thanks for the report.

    Edit: Nevermind, I found out what happened. This will be fixed for the next release. Sorry for the inconvenience.