Success! Looks like we've fixed this one. According to our records the fix was applied for TOUCH-3036 in Sprint 22 (2.0.2).
  1. 19 Jun 2012 11:48 AM #1
    cbobo
    cbobo is offline
    Sencha Premium Member
    Join Date
    Feb 2012
    Posts
    10
    Vote Rating
    1
    cbobo is on a distinguished road
      1  

    Exclamation v2.0.1.1 data/Writer.js getRecordData() should be passing field.config to writeDate()

    v2.0.1.1 data/Writer.js getRecordData() should be passing field.config to writeDate()


    The date is always written as timestamp because field.dateFormat doesn't exist.

    writeDate: function(field, date) {
    var dateFormat = field.dateFormat || 'timestamp';


    In v2.0.1 The fieldConfig was cached as fieldConfig and passed as the first parameter to writeDate()
    Line 137: value = this.writeDate(fieldConfig, value);

    In v2.0.1.1 The field itself is passed to writeDate() and the field doesn't have a dateFormat property.
    Line 136: value = this.writeDate(field, value);


    I suggest renaming the first writeDate parameter to fieldConfig.
    Also, please write a unit test for this. Such a simple test to write.

    Thanks,
    Bobo
    Reply With Quote Reply With Quote
  2. 20 Jun 2012 6:02 AM #2
    mitchellsimoens
    mitchellsimoens is offline
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    St. Louis, MO
    Posts
    33,582
    Vote Rating
    433
    mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of mitchellsimoens has much to be proud of
      0  

    Default


    Thanks for the report.
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    http://www.JSONPLint.com - Source to lint your JSONP!

    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is almost in print!

    When posting code, please use BBCode's CODE tags.
    Reply With Quote Reply With Quote
  3. 25 Jun 2012 9:32 AM #3
    TommyMaintz
    TommyMaintz is offline
    Sencha - Sencha Touch Dev Team
    Join Date
    Mar 2007
    Location
    Haarlem, Netherlands
    Posts
    1,235
    Vote Rating
    4
    TommyMaintz will become famous soon enough
      0  
    Send a message via MSN to TommyMaintz Send a message via Yahoo to TommyMaintz Send a message via Skype™ to TommyMaintz

    Default


    Hmm, I don't understand how this made it into the build. The code in the current repository is correct and the unit tests are passing for this method. Thanks for the report.

    Edit: Nevermind, I found out what happened. This will be fixed for the next release. Sorry for the inconvenience.
    Reply With Quote Reply With Quote