stopEvent, stopPropagation not working as expected.

[codydjango]

I have an columngrid with two columns: the second is an actioncolumn.


I'd like it so that a click on the column is passed to the click handler, unless the user clicks on an action in the action column.


I implemented e.stopEvent() in the actioncolumn handlers. This has no effect. The event first triggers the clicked-upon action handler, then triggers the column handler, then triggers the rowclick handler, despite e.stopEvent in each handler. I'm using the default Ext scoping scheme.


Can someone explain why this is happening? Could there be Ext 3.4 options for how event bubbling is handled?


Thanks.

[sword-it]

Hi,

I checked ActionColumn definition and found this:

processEvent: function (name, e, grid, rowIndex, colIndex) {
        var m = e.getTarget().className.match(this.actionIdRe),
            item, fn;
        if (m && (item = this.items[parseInt(m[1], 10)])) {
            if (name == 'click') {
                (fn = item.handler || this.handler) && fn.call(item.scope || this.scope || this, grid, rowIndex, colIndex, item, e);
            } else if ((name == 'mousedown') && (item.stopSelection !== false)) {
                return false;
            }
        }
        return Ext.grid.ActionColumn.superclass.processEvent.apply(this, arguments);
    }

Looks like there is nothing to check if handler returns false or something. So we need to overwrite it:

Ext.override(Ext.grid.ActionColumn, {
    processEvent : function(name, e, grid, rowIndex, colIndex){
        var m = e.getTarget().className.match(this.actionIdRe),
            item, fn;
        if (m && (item = this.items[parseInt(m[1], 10)])) {
            if (name == 'click') {
                fn = item.handler || this.handler;
                if(fn){
                    if(fn.call(item.scope || this.scope || this, grid, rowIndex, colIndex, item, e) === false){
                        return false;
                    }
                }
            } else if ((name == 'mousedown') && (item.stopSelection !== false)) {
                return false;
            }
        }
        return Ext.grid.ActionColumn.superclass.processEvent.apply(this, arguments);
    }
});

or

{
xtype: 'actioncolumn',
....
processEvent : function(name, e, grid, rowIndex, colIndex){
        var m = e.getTarget().className.match(this.actionIdRe),
            item, fn;
        if (m && (item = this.items[parseInt(m[1], 10)])) {
            if (name == 'click') {
                fn = item.handler || this.handler;
                if(fn){
                    if(fn.call(item.scope || this.scope || this, grid, rowIndex, colIndex, item, e) === false){
                        return false;
                    }
                }
            } else if ((name == 'mousedown') && (item.stopSelection !== false)) {
                return false;
            }
        }
        return Ext.grid.ActionColumn.superclass.processEvent.apply(this, arguments);
    }
}

And 'return false' would cancel your click event.

Regards.

[rich02818]

Has this been logged into the problem system for v3.4? What is the assigned number? Will this fix be in 3.4.1?