1. #1
    Ext User
    Join Date
    Mar 2007
    Posts
    17
    Vote Rating
    0
    seno is on a distinguished road

      0  

    Default where is GridView.onRemove ?

    where is GridView.onRemove ?


    i remove a record in grid using ds.remove(record) method
    but can't remove record with the same error:
    l.fireFn has no properties

    GridView.js
    Code:
    if(ds){
          ds.on("datachanged", this.onDataChange, this);
          ds.on("add", this.onAdd, this);
          ds.on("remove", this.onRemove, this);
          ds.on("update", this.onUpdate, this);
          ds.on("clear", this.onClear, this);
    }
    but i can't find GridView.OnRemove method, this is a bug or not completed
    sorry for my english

  2. #2
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    17
    jack.slocum will become famous soon enough jack.slocum will become famous soon enough

      0  

    Default


    It's a bug, the function is there but it's called "onDelete". I renamed onDelete to onRemove and all is well (also a change in onUpdate where it calls onDelete).

  3. #3
    Ext User
    Join Date
    Mar 2007
    Posts
    17
    Vote Rating
    0
    seno is on a distinguished road

      0  

    Default


    i rename onDelete to onRemove,but there is another bug

    Store.js
    Code:
        remove : function(record){
            var index = this.data.indexOf(record);
            this.data.removeAt(index);
            this.fireEvent("remove", this, record, index);
        }
    ds.remove method delete record, then fire GridView.onRemove
    Code:
    onRemove : function(ds, record, isUpdate){
            var index = typeof record == "number" ? record : this.ds.indexOf(record);
            ...
        }
    index always be -1 because record is deleted

  4. #4
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    17
    jack.slocum will become famous soon enough jack.slocum will become famous soon enough

      0  

    Default


    I redeployed - check the new version.

  5. #5
    Sencha User
    Join Date
    Mar 2007
    Posts
    29
    Vote Rating
    0
    cchiriac is on a distinguished road

      0  

    Default


    same function name problem in View.js (onDelete vs. onRemove)

    Also, there are references to
    Code:
    this.ds
    It should be
    Code:
    this.store
    now, right ?



    Code:
    onDelete : function(ds, record){
            this.clearSelections();
            var index = this.ds.indexOf(record);
            this.el.dom.removeChild(this.nodes[index]);
            this.updateIndexes(index);
        }
    Code:
     onUpdate : function(ds, record){
            this.clearSelections();
            var index = this.ds.indexOf(record);
            var n = this.nodes[index];
            this.tpl.insertBefore(n, this.prepareData(record.data));
            n.parentNode.removeChild(n);
            this.updateIndexes(index, index);
        }

  6. #6
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    17
    jack.slocum will become famous soon enough jack.slocum will become famous soon enough

      0  

    Default


    Thanks, I put in your fixes.

Similar Threads

  1. GridView bufferRows FF bug?
    By ericwaldheim in forum Ext 2.x: Help & Discussion
    Replies: 4
    Last Post: 22 Mar 2007, 8:42 AM
  2. line 202 of widgets\grid\GridView.js
    By papasi in forum Ext 1.x: Bugs
    Replies: 1
    Last Post: 20 Mar 2007, 10:27 PM
  3. gridview error: re is not defined
    By hicker in forum Ext 2.x: Help & Discussion
    Replies: 3
    Last Post: 17 Mar 2007, 12:25 AM
  4. Issue with focus on selected row in GridView.js
    By gcsolaroli in forum Ext 1.x: Bugs
    Replies: 0
    Last Post: 15 Jan 2007, 9:24 AM
  5. GridView Cell Align
    By Micha in forum Ext 1.x: Help & Discussion
    Replies: 6
    Last Post: 20 Dec 2006, 11:49 AM

Thread Participants: 2