Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-7269 in a recent build.
  1. #1
    Sencha Premium Member
    Join Date
    Nov 2009
    Posts
    92
    Vote Rating
    3
    tomb@ibcos.co.uk is on a distinguished road

      0  

    Default Ext.data.NodeInterface remove doesn't call destroy if parent is null

    Ext.data.NodeInterface remove doesn't call destroy if parent is null


    REQUIRED INFORMATION

    Ext version tested:
    • Ext 4.1.2
    Description:
    • If this.parentNode is null, destroy isn't called
    Code:
    /**
    * Removes this node from its parent
    * @param {Boolean} [destroy=false] True to destroy the node upon removal.
    * @return {Ext.data.NodeInterface} this
    */
    remove : function(destroy, suppressEvents) {
        var parentNode = this.parentNode;
    
    
        if (parentNode) {
            parentNode.removeChild(this, destroy, suppressEvents);
        }
        return this;
    },
    HELPFUL INFORMATION

    Possible fix:

    Code:
    /**
    * Removes this node from its parent
    * @param {Boolean} [destroy=false] True to destroy the node upon removal.
    * @return {Ext.data.NodeInterface} this
    */
    remove : function(destroy, suppressEvents) {
        var parentNode = this.parentNode;
    
    
        if (parentNode) {
            parentNode.removeChild(this, destroy, suppressEvents);
        } else if (destroy) {
            this.destroy(true);
        }
        return this;
    },

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    37,206
    Vote Rating
    856
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      1  

    Default


    This has been fixed for 4.1.3
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

Thread Participants: 1