Button.setIconCls - doesn't check if icon class changed

[LesJ]

The Button.setIconCls method does not check if the class actually changed before resetting the value.

Is this intentional?

Ext.define('Ext.button.Button', {
    ...
    setIconCls: function(cls) {
        var me = this,
            btnIconEl = me.btnIconEl,
            oldCls = me.iconCls;
            
        me.iconCls = cls;
        if (btnIconEl) {
            // Remove the previous iconCls from the button
            btnIconEl.removeCls(oldCls);
            btnIconEl.addCls(cls || '');
            me.setComponentCls();
            if (me.didIconStateChange(oldCls, cls)) {
                me.updateLayout();
            }
        }
        return me;
    },
    ....

[mitchellsimoens]

I think it can do a simple if statement to check to stop it if it doesn't need to. We will discuss this internally, opening a bug for it.

[evant]

The didStateChange checks: Did we go from having no icon to having an icon or vice versa.

But yes, we could probably add in a check there, not really a bug though.