[4.1.2] Ext.app.Application overwrites MyApp.app namespace

[damien]

REQUIRED INFORMATION


Ext version tested:

• Ext 4.1.2

Browser versions tested against:

• not relevant

Description:

• ExtJs 4.1.2 introduced the new 'feature' where Ext.app.Application assigns itself to 'MyApp.app' (with MyApp being the application namespace as defined by the appName property)
• This didn't consider that users might actually use this path as namespace for class definitions, e.g. 'MyApp.app.MyClass'

Steps to reproduce the problem:

• Create a class in your application's namespace in a package named 'app', like so: Ext.define('MyApp.app.SomeClass')

The result that was expected:

• The class being available and accessible via the defined namespace

The result that occurs instead:

• The class not being available and accessible via the defined namespace

Test Case:

Ext.define('MyApp.app.SomeClass', { singleton: true, property: 'prop' /*...*/});
Ext.application({
   uses: ['MyApp.app.SomeClass'],
   appName: 'MyApp',
   launch: function() {
      console.log(MyApp.app.SomeClass.property === 'prop');  // FAILS: SomeClass is undefined
   }
});

[mitchellsimoens]

So what would you like us to do? Have a config for where to cache the Ext.application instance?

[damien]

Well,
a config or
template method or
a function Ext.app.Application#getApp() or
disable the feature by default or
...

I guess that is a decision that a Sencha developer should make.

[damien]

This 'feature' was introduced in 4.1.2. Maybe not the best time to do so in a maintenance release.

Also, I recommend finding a prominent place to document the fact that it is not possible to use namespaces/class names with 'appname.app'.

It is not really obvious what is happening when it happens.


EDIT:
Maybe a good way around the documentation problem is to throw an exception when assigning the application object to a property that is not empty - and include a reference to how to reconfigure the application.

[mitchellsimoens]

Well,
a config or
template method or
a function Ext.app.Application#getApp() or
disable the feature by default or
...

I guess that is a decision that a Sencha developer should make.

The only reason I ask is when people wanted this, they all were wanting it to be on the app property.

[evant]

@OP Agreed.

I've pushed up a fix so it will now be configurable by an appProperty config. Also, it will throw a warning if the default is left in place and it's overwriting something.

[damien]

@evan
thx.

@mitchell
thx for asking
I am happy with the chosen approach.