BUG: Ext.data.Types BOOL is casesensitive

[jim@carroll.net]

Models that include 'boolean' fields are either required to provide all lowercase boolean strings OR to write a convert() function for every field that uses boolean in their Model declarations.

Here's the relevant snippet from Ext.data.Types

BOOL: {
    convert: function(v) {
        if (this.useNull && (v === undefined || v === null || v === '')) {
            return null;
        }
        return v === true || v === 'true' || v == 1;
    },
    sortType: st.none,
    type: 'bool'

I think it would be more intuitive if it did more like:

BOOL: {
    convert: function(v) {
        if (this.useNull && (v === undefined || v === null || v === '')) {
            return null;
        }
        return Boolean(v);
    },
    sortType: st.none,
    type: 'bool'

No?

[mitchellsimoens]

Boolean(v) won't work because this would return true:

Boolean('I should be false')

Now the v === 'true' could be:

/true/i.test(v)

And that would be case-insensitive

[jim@carroll.net]

You're right (of course)

But the fact that the current incarnation is case sensitive makes this a bit cumerbsome. For example, we have a model associated with an Ajax proxy. The server in this case is returning 'True' for its booleans. It means everywhere we use 'boolean' in our extjs model's, we need to add a covert() method for each individual field that coerces to lowercase.

Of course, we could probably create our own Ext.type.Type for something like CSBOOL -- but we use Sencha Architect for our coding activity -- and I'm not sure if we'd be able to refer to this custom type from SA.

It seems to me that it would make syntactic sense to modify the base type, no?

[evant]

This isn't a bug, the docs are clear on what the bool type will convert automatically. The overhead of doing a case insensitive comparison isn't worth it for the small use case, especially since you can create your own types quite easily.