Store::sort() method may be improved a bit

[zerkms]

The extjs version I'm talking about is 4.1.2a

Currently the sort method of Extjs.data.Store looks like

    sort: function() {
        var me = this,
            prefetchData = me.pageMap;


        if (me.buffered) {
            if (me.remoteSort) {
                prefetchData.clear();
                me.callParent(arguments);
            } else {
                me.callParent(arguments);
            }
        } else {
            me.callParent(arguments);
        }
    },

it can be reduced to something a bit more readable and short:

    sort: function() {
        var me = this,
            prefetchData = me.pageMap;


        if (me.buffered && me.remoteSort) {
            prefetchData.clear();
        }
        
        me.callParent(arguments);
    },

[evant]

Not really a bug, but yeah, that code certainly isn't great. Will fix it up, cheers.

[LesJ]

Store.sort inherits form AbstractStore, but AbstractStore doesn't have the sort method, so why are we calling callParent?

[evant]

It does, it's mixed in by sortable.

[LesJ]

It does, it's mixed in by sortable.

I see, good point.

But, sortable.sort returns sorters, so we should probably call:

return me.callParent(arguments);