Toolbar setVisible logic broken with enableOverflow is true

[arun_v]

REQUIRED INFORMATION
Ext version tested:

• Ext 4.1.1

Browser versions tested against:

• Chrome 23.0.1271.6 dev-m

Description:

• When enableOverflow is set to true in a toolbar, the setVisible method doesn't actually toggle the visibility of any items that are in the toolbar

Steps to reproduce the problem:

• Make a toolbar with enableOverflow true
• put in enough items that the overflow menu appears
• try to use setVisible(false) on a child item that is now in the menu

The result that was expected:

• Item should be invisible

The result that occurs instead:

• Item is still visible

Test Case:

var button1 = new Ext.button.Button({
text: 'Button1'
});
var button2 = new Ext.button.Button({
text: 'Button2'
});
var button3 = new Ext.button.Button({
text: 'Button3'
});
var button4 = new Ext.button.Button({
text: 'Button4'
});
var button5 = new Ext.button.Button({
text: 'Button5'
});
var button6 = new Ext.button.Button({
text: 'Button6'
});

new Ext.button.Button({
text: 'Make 4,5,6 invisible',
renderTo: document.body,
handler: function() {
button4.setVisible(false);
button5.setVisible(false);
button6.setVisible(false);
}
});

new Ext.button.Button({
text: 'Make 4,5,6 visible',
renderTo: document.body,
handler: function() {
button4.setVisible(true);
button5.setVisible(true);
button6.setVisible(true);
}
});

new Ext.toolbar.Toolbar({
renderTo: document.body,
width   : 200,
enableOverflow: true,
items: [button1, button2, button3, button4, button5, button6]
});
​

HELPFUL INFORMATION
See this URL for live test case:

• http://jsfiddle.net/2vsU5/15/

Possible fix:

• not provided

Operating System:

• Windows 7 version 6.1(Build 7601: Service Pack 1)

Earlier report of same bug in Ext 3.x:

• http://www.sencha.com/forum/showthre...low+setvisible

[mitchellsimoens]

So you are saying that the setVisible should toggle the menu items in the overflow menu correct?

[arun_v]

Correct. It seems like it should follow like that since the overflow menu is enabled with just a boolean in the toolbar config.

[mitchellsimoens]

Thanks for the report! I have opened a bug in our bug tracker.