ST2.1 RC2 Crash when new SQL Proxy without "filter"

[rkraus]

Hi,

when I use the new Ext.data.proxy.SQL to save my data I run into:

• [COLOR=red !important]Uncaught TypeError: Cannot read property 'length' of null SQL.js:268[/COLOR]
  • [COLOR=red !important]Ext.define.selectRecords[/COLOR]SQL.js:268
  • [COLOR=red !important](anonymous function)[/COLOR]SQL.js:108

[mitchellsimoens]

Can I get a locally runnable test case to reproduce?

[Möhre]

Same prob? With solution!

ST2.1-RC2-SQL-Proxy-accessing-incorrect-Filter-property

[rkraus]

Will this patch be in the next nightly build?

[rkraus]

Hi,

It won´t fix my problem...

I have problems with line 268 !

ln = params.filters.length;

When there are no filters setup in the proxy config...

[rkraus]

I fixed it....

Index: touch/src/data/proxy/SQL.js===================================================================
--- touch/src/data/proxy/SQL.js	(revision 6988)
+++ touch/src/data/proxy/SQL.js	(working copy)
@@ -110,23 +110,25 @@
                     me.fireEvent('exception', me, operation);
                 }
 
-                if (filters.length) {
-                    filtered = Ext.create('Ext.util.Collection', function(record) {
-                        return record.getId();
-                    });
-                    filtered.setFilterRoot('data');
-                    for (i = 0, ln = filters.length; i < ln; i++) {
-                        if (filters[i].getProperty() === null) {
-                            filtered.addFilter(filters[i]);
-                        }
-                    }
-                    filtered.addAll(operation.getRecords());
+								if (params.sorters != null) {
+									if (filters.length) {
+											filtered = Ext.create('Ext.util.Collection', function(record) {
+													return record.getId();
+											});
+											filtered.setFilterRoot('data');
+											for (i = 0, ln = filters.length; i < ln; i++) {
+													if (filters[i].getProperty() === null) {
+															filtered.addFilter(filters[i]);
+													}
+											}
+											filtered.addAll(operation.getRecords());
 
-                    operation.setRecords(filtered.items.slice());
-                    resultSet.setRecords(operation.getRecords());
-                    resultSet.setCount(filtered.items.length);
-                    resultSet.setTotal(filtered.items.length);
-                }
+											operation.setRecords(filtered.items.slice());
+											resultSet.setRecords(operation.getRecords());
+											resultSet.setCount(filtered.items.length);
+											resultSet.setTotal(filtered.items.length);
+									}
+								}
 
                 if (typeof callback == 'function') {
                     callback.call(scope || me, operation);
@@ -265,35 +267,40 @@
         if (!Ext.isObject(params)) {
             sql += filterStatement + idProperty + ' = ' + params;
         } else {
-            ln = params.filters.length;
-            if (ln) {
-                for (i = 0; i < ln; i++) {
-                    filter = params.filters[i];
-                    property = filter.getProperty();
-                    value = filter.getValue();
-                    if (property !== null) {
-                        sql += filterStatement + property + ' ' + (filter.anyMatch ? ('LIKE \'%' + value + '%\'') : ('= \'' + value + '\''));
-                        filterStatement = ' AND ';
-                    }
-                }
-            }
 
-            ln = params.sorters.length;
-            if (ln) {
-                for (i = 0; i < ln; i++) {
-                    sorter = params.sorters[i];
-                    property = sorter.getProperty();
-                    if (property !== null) {
-                        sql += sortStatement + property + ' ' + sorter.getDirection();
-                        sortStatement = ', ';
-                    }
-                }
-            }
+					if (params.sorters != null) {
+						ln = params.sorters.length;
+						if (ln) {
+							for (i = 0; i < ln; i++) {
+								sorter = params.sorters[i];
+								property = sorter.getProperty();
+								if (property !== null) {
+									sql += sortStatement + property + ' ' + sorter.getDirection();
+									sortStatement = ', ';
+								}
+							}
+						}
+					}
 
-            // handle start, limit, sort, filter and group params
-            if (params.page !== undefined) {
-                sql += ' LIMIT ' + parseInt(params.start, 10) + ', ' + parseInt(params.limit, 10);
-            }
+					if (params.filters != null) {
+						ln = params.filters.length;
+						if (ln) {
+							for (i = 0; i < ln; i++) {
+								filter = params.filters[i];
+								property = filter.getProperty();
+								value = filter.getValue();
+								if (property !== null) {
+									sql += filterStatement + property + ' ' + (filter.getAnyMatch() ? ('LIKE \'%' + value + '%\'') : ('= \'' + value + '\''));
+									filterStatement = ' AND ';
+								}
+							}
+						}
+					}
+
+					// handle start, limit, sort, filter and group params
+					if (params.page !== undefined) {
+							sql += ' LIMIT ' + parseInt(params.start, 10) + ', ' + parseInt(params.limit, 10);
+					}
         }
 
         transaction.executeSql(sql, null,