[4.1.1] IE7 memory leak after adding combobox to htmleditor toolbar

**Jotnar** · 26 Oct 2012 12:10 PM

This is my second attempt at reporting this. The first post was deleted with no explanation.
MODS: if there is a problem with the format or content please let me know and I will correct it.

REQUIRED INFORMATION

Ext version tested:

Ext 4.1.1

Browser versions tested against:

IE7
IE8
IE9

Description:

Adding a combo box to the toolbar of Ext.form.HtmlEditor causes a large memory leak in IE7 on page unload. This memory is not garbage collected and never goes away. It will continue to rise about 30MB each time the component is unloaded. This does not appear to be an issue in IE8 or IE9. I have not tested it on IE6.

Steps to reproduce the problem:

See test case below.

The result that was expected:

Memory should return to pre page load level after navigating away from page.

The result that occurs instead:

Memory increases about 30MB each time page is unloaded.

Test Case:

Code:

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">


<link rel="stylesheet" type="text/css" href="http://extjs.cachefly.net/ext-4.1.1-gpl/resources/css/ext-all.css">
<script src="http://extjs.cachefly.net/ext-4.1.1-gpl/ext-all-debug.js"></script>


<script type="text/javascript">  
Ext.onReady(function() {
    Ext.define('CustomEditor', {
        extend : 'Ext.form.HtmlEditor',
        initComponent : function() {
            this.callParent(arguments);
            
            var toolbar = this.getToolbar();
            toolbar.add('->', 'Label:'
                // Comment out the combo, and no memory leak!
                ,{
                    xtype : 'combo',
                    width : 100
                }
            );
        }
    });
    
    Ext.create('CustomEditor', {
        width : 700,
        height : 250,
        renderTo : 'editDiv'
    });
});
</script>
</head>
<body>
    <div id="editDiv">&nbsp;</div>
</body>
</html>

HELPFUL INFORMATION

Debugging already done:

Comment out the combo box in the code above and there won't be a leak.

Possible fix:

not provided

Additional CSS used:

only default ext-all.css

Operating System:

WinXP Pro (IE7/8)
Win7 (IE9)

**mitchellsimoens** · 27 Oct 2012 12:34 AM

I'm not seeing this. In beforeDestroy it does Ext.destroyMembers which will destroy the toolbar and it's items.

**Jotnar** · 30 Oct 2012 8:39 AM

What version of IE7 did you test this with?

I can reproduce it in the following environments:
Lenovo T61 2.2GHz/2GB RAM
XP Pro SP3
IE7 version 7.0.5730.13

Memory usage with combo:
19,024 about:blank
70,692 load
94,908 1rst refresh
118,880
143,536
167,380
191,204
215,484
239,372
263,204
286,944
310,724 10th refresh
...
551,820 20th refresh
...
1,269,416 50th refresh

Memory usage without combo:
19,024 about:blank
70,008 load
70,768 1rst refresh
71,140
71,224
71,312
71,556
71,776
72,144
71,892
72,068
71,916 10th refresh

I also got similar results using:
Virtual Machine 2.39GHz/1GB RAM
Windows Server 2003 Enterprise Edition SP2
IE7 version 7.0.5730.11

When I set break points in Firefox/Firebug, it seems that the HtmlEditor beforeDestroy function is never called. I see it getting set in initEditor, but it doesn't stop anywhere in beforeDestroy. If that's the case then the component is never getting cleaned up.

**Jotnar** · 31 Oct 2012 8:59 AM

Some more debugging: I overrode the initEditor function of HtmlEditor and replaced

Code:

Ext.EventManager.on(window, 'unload', me.beforeDestroy, me);

with

Code:

Ext.EventManager.onWindowUnload(me.beforeDestroy, me);

and now beforeDestroy is running in both Firefox and IE7. However the memory leak is still there in IE7. Stepping through the code in Firefox it does appear that all the items on the toolbar are getting removed/destroyed, as well as the toolbar from the editor, so I'm still at a loss as to what's going on in IE7.

**evant** · 31 Oct 2012 6:49 PM

I agree it should use the onWindowUnload method. However, IE6/7 are notoriously bad for iframe memory management. For example, you can load up a page where you include an iframe pointing to google and you'll see the memory grow on each refresh. I'm not really sure if there's a whole lot we can do to resolve the issue.

[4.1.1] IE7 memory leak after adding combobox to htmleditor toolbar

Thread Tools

Search Thread

Display

[4.1.1] IE7 memory leak after adding combobox to htmleditor toolbar

[4.1.1] IE7 memory leak after adding combobox to htmleditor toolbar

Tags for this Thread