Hybrid View

    Success! Looks like we've fixed this one. According to our records the fix was applied for TOUCH-3640 in a recent build.
  1. #1
    Sencha Premium Member
    Join Date
    Apr 2008
    Posts
    266
    Vote Rating
    28
    themightychris has a spectacular aura about themightychris has a spectacular aura about

      0  

    Default 2.1.0rc2 - Element.traversal.js overwrites Element.select with broken implementation

    2.1.0rc2 - Element.traversal.js overwrites Element.select with broken implementation


    The file /touch/src/dom/Element.traversal.js, which is not referenced anywhere in the docs, overwrites the Element.select implementation referenced in the docs with this one:

    Code:
        select: function(selector, composite) {
            return Ext.dom.Element.select(selector, this.dom, composite);
        }
    ...which gets the parameters to Ext.dom.Element.select wrong, causing the select to find elements across the entire document rather than within the scope of the element

    Snapshot 10:30:12 6:50 PM.png
    Chief Architect @ Jarv.us Innovations
    Co-captain @ Code for Philly

    Jarvus builds and optimizes top-quality Sencha Touch and ExtJS apps for open-source projects and clients of all sizes.

    Don't waste time with bugs that have already been found and fixed by the community, compile our tried and tested hotfixes packages into all your projects: https://github.com/JarvusInnovations/sencha-hotfixes

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    37,547
    Vote Rating
    872
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    Thanks for the report! I have opened a bug in our bug tracker.

  3. #3
    Sencha Premium Member
    Join Date
    Apr 2008
    Posts
    266
    Vote Rating
    28
    themightychris has a spectacular aura about themightychris has a spectacular aura about

      0  

    Default


    This is still broken in 2.1 GA... how many devs are pulling their hair out from Element.select misbehaving?
    Chief Architect @ Jarv.us Innovations
    Co-captain @ Code for Philly

    Jarvus builds and optimizes top-quality Sencha Touch and ExtJS apps for open-source projects and clients of all sizes.

    Don't waste time with bugs that have already been found and fixed by the community, compile our tried and tested hotfixes packages into all your projects: https://github.com/JarvusInnovations/sencha-hotfixes

  4. #4
    Sencha Premium Member
    Join Date
    Apr 2008
    Posts
    266
    Vote Rating
    28
    themightychris has a spectacular aura about themightychris has a spectacular aura about

      0  

    Default


    I can't believe Element.select is still completely broken and the documented params for Ext.select are still wrong in 2.2:

    Test to reproduce:

    Open http://docs.sencha.com/touch/2.2.0/t...ink/index.html

    In the console, compare the results of these two expressions:
    Code:
    Ext.get('mainNavigationBar').select('.x-inner').getCount();
    Ext.dom.Element.select('.x-inner', false, 'mainNavigationBar').getCount();
    Screen Shot 2013-04-28 at 4.53.23 PM.png
    Chief Architect @ Jarv.us Innovations
    Co-captain @ Code for Philly

    Jarvus builds and optimizes top-quality Sencha Touch and ExtJS apps for open-source projects and clients of all sizes.

    Don't waste time with bugs that have already been found and fixed by the community, compile our tried and tested hotfixes packages into all your projects: https://github.com/JarvusInnovations/sencha-hotfixes

  5. #5
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    18
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    The static method has 3 arguments, the instance's has 2 since the root is the instance itself.

    Documentation fixed for both methods and the instance's and the instance was sending the arguments in the wrong order and has been fixed.

    Sencha Inc

    Jamie Avins

    @jamieavins

Thread Participants: 2