Hybrid View
-
30 Oct 2012 2:53 PM #1
2.1.0rc2 - Element.traversal.js overwrites Element.select with broken implementation
2.1.0rc2 - Element.traversal.js overwrites Element.select with broken implementation
The file /touch/src/dom/Element.traversal.js, which is not referenced anywhere in the docs, overwrites the Element.select implementation referenced in the docs with this one:
...which gets the parameters to Ext.dom.Element.select wrong, causing the select to find elements across the entire document rather than within the scope of the elementCode:select: function(selector, composite) { return Ext.dom.Element.select(selector, this.dom, composite); }
Snapshot 10:30:12 6:50 PM.png
-
30 Oct 2012 4:16 PM #2Sencha - Senior Forum Manager
- Join Date
- Mar 2007
- Location
- St. Louis, MO
- Posts
- 33,624
- Vote Rating
- 434
Thanks for the report! I have opened a bug in our bug tracker.
-
15 Dec 2012 4:54 PM #3
This is still broken in 2.1 GA... how many devs are pulling their hair out from Element.select misbehaving?
-
28 Apr 2013 12:53 PM #4
I can't believe Element.select is still completely broken and the documented params for Ext.select are still wrong in 2.2:
Test to reproduce:
Open http://docs.sencha.com/touch/2.2.0/t...ink/index.html
In the console, compare the results of these two expressions:
Screen Shot 2013-04-28 at 4.53.23 PM.pngCode:Ext.get('mainNavigationBar').select('.x-inner').getCount(); Ext.dom.Element.select('.x-inner', false, 'mainNavigationBar').getCount();
-
29 Apr 2013 10:34 AM #5Sencha - Sencha Touch Dev Team
- Join Date
- Mar 2007
- Location
- Redwood City, California
- Posts
- 3,652
- Vote Rating
- 14
The static method has 3 arguments, the instance's has 2 since the root is the instance itself.
Documentation fixed for both methods and the instance's and the instance was sending the arguments in the wrong order and has been fixed.
Success! Looks like we've fixed this one. According to our records the fix was applied for
TOUCH-3640
in
2.2.


Reply With Quote