-
17 Nov 2012 6:42 AM #1
Ext.Array.forEach - redundant return statement
Ext.Array.forEach - redundant return statement
This is a minor point, but the return statement below is redundant because the native Array.forEach implementation has no return value, and if it did have a return value, then it would not be consistent with the non-native implementation which doesn't have the return statement.
As a side note, I'm not sure why the native implementation doesn't return the array. It would be nice if it did, then we would be able to chain forEach.
Ext.Array.forEach could also return the array, but then the api would not be conformant with the native api.
https://developer.mozilla.org/en-US/.../Array/forEach
Code:ExtArray = Ext.Array = { ... forEach: supportsForEach ? function(array, fn, scope) { return array.forEach(fn, scope); // <==== return not needed } : function(array, fn, scope) { var i = 0, ln = array.length; for (; i < ln; i++) { fn.call(scope, array[i], i, array); } } ...
-
18 Nov 2012 3:40 PM #2Sencha - Senior Forum Manager
- Join Date
- Mar 2007
- Location
- St. Louis, MO
- Posts
- 33,656
- Vote Rating
- 435
thanks for the report
Mitchell Simoens @SenchaMitch
Sencha Inc, Senior Forum Manager
________________
http://www.JSONPLint.com - Source to lint your JSONP!
Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
https://github.com/mitchellsimoens
Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/
Need more help with your app? Hire Sencha Services services@sencha.com
Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is almost in print!
When posting code, please use BBCode's CODE tags.
Success! Looks like we've fixed this one. According to our records the fix was applied for
EXTJSIV-7777
in
4.2.0.


Reply With Quote