Bug in the 2.1 list implementation

[troels]

Hello Sencha,

I think we've found a bug in the new list implementation provided with Sencha 2.1.

The method

getItemIndex: function(item) {
    var index = item.dataIndex;
    return (index === -1) ? index : this.indexOffset + index;    
},

The indexOffset is the absolute list index of the top item in the view list (use list.getViewItems()), but the item indices (dataIndex) seems to be calculated using absolute index in the onTranslate method. Therefore an indexOffset > 0 will yield a bad index for the item.

[mitchellsimoens]

Thanks for the report! I have opened a bug in our bug tracker.

[mitchellsimoens]

I used the list example and scrolled down to the D group and did this:

var list = Ext.ComponentQuery.query('list')[0],
    idx  = list.getStore().indexOf(list.listItems[0].getRecord());

which gave me 36 as the index of the first D record. I then did this:

var list = Ext.ComponentQuery.query('list')[0],
    idx  = list.getItemIndex(list.listItems[0]);

and it gave me 72.

[TommyMaintz]

This function is there as legacy code and is not used anywhere in our framework or examples. It's logic is indeed flawed it seems. The question is whether we want to return the "data index" of the record bound to the item, or the index of the item in the listItems array (which seems pointless info to me). So for now I have just updated the method to become like this for the next release:

    /**
     * Returns an index for the specified item.
     * @param {Number} item The item to locate.
     * @return {Number} Index of the record bound to the specified item.
     */
    getItemIndex: function(item) {
        return item.dataIndex;
    }

Is this what you would expect the function to return as well?

Best,
Tommy

[troels]

Hello Tommy,

Yes, that's exactly what I'd expect and it's identical to my "overrides:" fix currently in use. Thanks!