Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-8213 in a recent build.
  1. #1
    Sencha Premium Member
    Join Date
    Jan 2010
    Location
    Vancouver, Canada
    Posts
    137
    Vote Rating
    29
    bogc will become famous soon enough bogc will become famous soon enough

      0  

    Default beforeload is not fired by loadRawData

    beforeload is not fired by loadRawData


    Ext version tested:
    • Ext 4.2 Beta 2

    Browser versions tested against:
    • Chrome 23.0.1271.97 m
    Description:

    I am not 100% sure this is a bug, it might be by design for various reasons, but loadRawData doesn't fire the beforeload event. This may have side effects and it can be confusing.

    A side effect seems to be this bug: http://www.sencha.com/forum/showthread.php?176485

    It is confusing because the function fires the load event, so my expectation was that the beforeload event gets fired as well. These two events should act together as a pair, in my mind.

    I guess I can always call manually the fireEvent function on store before I make the loadRawData call, but still it doesn't feel right not to pair the two events together.

    Steps to reproduce the problem:

    I modified the array-grid.js sample.

    Code:
    Ext.require([
        'Ext.grid.*',
        'Ext.data.*',
        'Ext.util.*',
        'Ext.state.*'
    ]);
    
    // Define Company entity
    // Null out built in convert functions for performance *because the raw data is known to be valid*
    // Specifying defaultValue as undefined will also save code. *As long as there will always be values in the data, or the app tolerates undefined field values*
    Ext.define('Company', {
        extend: 'Ext.data.Model',
        fields: [
           {name: 'company'},
           {name: 'price',      type: 'float', convert: null,     defaultValue: undefined},
           {name: 'change',     type: 'float', convert: null,     defaultValue: undefined},
           {name: 'pctChange',  type: 'float', convert: null,     defaultValue: undefined},
           {name: 'lastChange', type: 'date',  dateFormat: 'n/j h:ia', defaultValue: undefined}
        ],
        idProperty: 'company'
    });
    
    Ext.onReady(function() {
        Ext.QuickTips.init();
        
        // setup the state provider, all state information will be saved to a cookie
        Ext.state.Manager.setProvider(Ext.create('Ext.state.CookieProvider'));
    
        // sample static data for the store
        var myData = [
            ['3m Co',                               71.72, 0.02,  0.03,  '9/1 12:00am'],
            ['Alcoa Inc',                           29.01, 0.42,  1.47,  '9/1 12:00am'],
            ['Altria Group Inc',                    83.81, 0.28,  0.34,  '9/1 12:00am'],
            ['American Express Company',            52.55, 0.01,  0.02,  '9/1 12:00am'],
            ['American International Group, Inc.',  64.13, 0.31,  0.49,  '9/1 12:00am'],
            ['AT&T Inc.',                           31.61, -0.48, -1.54, '9/1 12:00am'],
            ['Boeing Co.',                          75.43, 0.53,  0.71,  '9/1 12:00am'],
            ['Caterpillar Inc.',                    67.27, 0.92,  1.39,  '9/1 12:00am'],
            ['Citigroup, Inc.',                     49.37, 0.02,  0.04,  '9/1 12:00am'],
            ['E.I. du Pont de Nemours and Company', 40.48, 0.51,  1.28,  '9/1 12:00am'],
            ['Exxon Mobil Corp',                    68.1,  -0.43, -0.64, '9/1 12:00am'],
            ['General Electric Company',            34.14, -0.08, -0.23, '9/1 12:00am'],
            ['General Motors Corporation',          30.27, 1.09,  3.74,  '9/1 12:00am'],
            ['Hewlett-Packard Co.',                 36.53, -0.03, -0.08, '9/1 12:00am'],
            ['Honeywell Intl Inc',                  38.77, 0.05,  0.13,  '9/1 12:00am'],
            ['Intel Corporation',                   19.88, 0.31,  1.58,  '9/1 12:00am'],
            ['International Business Machines',     81.41, 0.44,  0.54,  '9/1 12:00am'],
            ['Johnson & Johnson',                   64.72, 0.06,  0.09,  '9/1 12:00am'],
            ['JP Morgan & Chase & Co',              45.73, 0.07,  0.15,  '9/1 12:00am'],
            ['McDonald\'s Corporation',             36.76, 0.86,  2.40,  '9/1 12:00am'],
            ['Merck & Co., Inc.',                   40.96, 0.41,  1.01,  '9/1 12:00am'],
            ['Microsoft Corporation',               25.84, 0.14,  0.54,  '9/1 12:00am'],
            ['Pfizer Inc',                          27.96, 0.4,   1.45,  '9/1 12:00am'],
            ['The Coca-Cola Company',               45.07, 0.26,  0.58,  '9/1 12:00am'],
            ['The Home Depot, Inc.',                34.64, 0.35,  1.02,  '9/1 12:00am'],
            ['The Procter & Gamble Company',        61.91, 0.01,  0.02,  '9/1 12:00am'],
            ['United Technologies Corporation',     63.26, 0.55,  0.88,  '9/1 12:00am'],
            ['Verizon Communications',              35.57, 0.39,  1.11,  '9/1 12:00am'],
            ['Wal-Mart Stores, Inc.',               45.45, 0.73,  1.63,  '9/1 12:00am']
        ];
    
        /**
         * Custom function used for column renderer
         * @param {Object} val
         */
        function change(val) {
            if (val > 0) {
                return '<span style="color:green;">' + val + '</span>';
            } else if (val < 0) {
                return '<span style="color:red;">' + val + '</span>';
            }
            return val;
        }
    
        /**
         * Custom function used for column renderer
         * @param {Object} val
         */
        function pctChange(val) {
            if (val > 0) {
                return '<span style="color:green;">' + val + '%</span>';
            } else if (val < 0) {
                return '<span style="color:red;">' + val + '%</span>';
            }
            return val;
        }
    
        // create the data store
        var store = Ext.create('Ext.data.ArrayStore', {
            model: 'Company',
            //data: myData,
            listeners: {
              beforeload: {
                 fn: function (store, operation, eOpts)
                 {
                   alert('beforeLoad');
                 }
              },
              load: {
                 fn: function (store, operation, eOpts)
                 {
                   alert('load');
                 }
              }
            }
        });
        
        store.loadRawData(myData);
    
        // create the Grid
        var grid = Ext.create('Ext.grid.Panel', {
            store: store,
            stateful: true,
            collapsible: true,
            multiSelect: true,
            stateId: 'stateGrid',
            columns: [
                {
                    text     : 'Company',
                    flex     : 1,
                    sortable : false,
                    dataIndex: 'company'
                },
                {
                    text     : 'Price',
                    width    : 75,
                    sortable : true,
                    renderer : 'usMoney',
                    dataIndex: 'price'
                },
                {
                    text     : 'Change',
                    width    : 75,
                    sortable : true,
                    renderer : change,
                    dataIndex: 'change'
                },
                {
                    text     : '% Change',
                    width    : 75,
                    sortable : true,
                    renderer : pctChange,
                    dataIndex: 'pctChange'
                },
                {
                    text     : 'Last Updated',
                    width    : 85,
                    sortable : true,
                    renderer : Ext.util.Format.dateRenderer('m/d/Y'),
                    dataIndex: 'lastChange'
                },
                {
                    menuDisabled: true,
                    sortable: false,
                    xtype: 'actioncolumn',
                    width: 50,
                    items: [{
                        icon   : '../shared/icons/fam/delete.gif',  // Use a URL in the icon config
                        tooltip: 'Sell stock',
                        handler: function(grid, rowIndex, colIndex) {
                            var rec = store.getAt(rowIndex);
                            alert("Sell " + rec.get('company'));
                        }
                    }, {
                        getClass: function(v, meta, rec) {          // Or return a class from a function
                            if (rec.get('change') < 0) {
                                return 'alert-col';
                            } else {
                                return 'buy-col';
                            }
                        },
                        getTip: function(v, meta, rec) {
                            if (rec.get('change') < 0) {
                                return 'Hold stock';
                            } else {
                                return 'Buy stock';
                            }
                        },
                        handler: function(grid, rowIndex, colIndex) {
                            var rec = store.getAt(rowIndex);
                            alert((rec.get('change') < 0 ? "Hold " : "Buy ") + rec.get('company'));
                        }
                    }]
                }
            ],
            height: 350,
            width: 600,
            title: 'Array Grid',
            renderTo: 'grid-example',
            viewConfig: {
                stripeRows: true,
                enableTextSelection: true
            }
        });
    });
    The result that was expected:

    The 'beforeload' alert message pops up as well

    The result that occurs instead:

    Only the 'load' alert message pops up.

    Operating System:
    • Windows 7 64 bit

  2. #2
    Sencha - Senior Forum Manager mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    37,640
    Vote Rating
    898
    mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute mitchellsimoens has a reputation beyond repute

      0  

    Default


    Thanks for the report.
    Mitchell Simoens @SenchaMitch
    Sencha Inc, Senior Forum Manager
    ________________
    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

  3. #3
    Sencha Premium Member vinay_omniscient's Avatar
    Join Date
    Feb 2013
    Posts
    3
    Vote Rating
    0
    vinay_omniscient is on a distinguished road

      0  

    Default Load event is not fired by loadRawData

    Load event is not fired by loadRawData


    in version 4.2.0 ', In Store.js , me.fireEvent('load', me, records, true) has been removed from
    loadRawData method. Is this get handled anywhere?
    Vinay Thube,
    Omniscient Software Pvt. Ltd.
    www.omniscient.co.in

  4. #4
    Sencha Premium Member
    Join Date
    Jan 2010
    Location
    Vancouver, Canada
    Posts
    137
    Vote Rating
    29
    bogc will become famous soon enough bogc will become famous soon enough

      0  

    Default


    I am upgrading now from 4.1 to 4.2 and I just noticed the same thing, the load event is not fired anymore which I relied upon to do some processing.

    Not sure what was the reason for removing the firing of the load event. I did a 4.2.1 source code search and store loadRawData is not invoked anywhere in the library. It could have been justified if there was some internal usage and in order to prevent recursive or duplicate calls it was decided to have it removed.

    Any explanation for this?

    Thanks

  5. #5
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    17,145
    Vote Rating
    673
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    Basically, loadRawData is more akin to loadData than load. Since loadData doesn't fire any events, nor should loadRawData.

    The thing is that loadRawData doesn't depend on any async processing, it must be called directly by the developer, so there's no real need for any events.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

  6. #6
    Sencha Premium Member
    Join Date
    Jan 2010
    Location
    Vancouver, Canada
    Posts
    137
    Vote Rating
    29
    bogc will become famous soon enough bogc will become famous soon enough

      0  

    Default


    It makes sense what you say, however, wouldn't have been better to wait until a major version was released (i.e. 4 -> 5)? In my mind minor releases should contain fixes and possible new minor functionality, but you shouldn't be doing breaking changes of this kind where the behavior of public functions is altered so drastically.
    I thought that upgrading from 4.1 to 4.2 should be a breeze.
    I patched back the function to fire the load event.

  7. #7
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    17,145
    Vote Rating
    673
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    It happened in 4.1 -> 4.2, typically we do have minor API changes in between .x releases. If we could only ever alter the API in major releases, it would make it quite difficult to get anywhere. Also, this isn't so much an API change as a bug, it was never intended to fire that event.

    I think
    altered so drastically.
    is a bit of an overstatement.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

  8. #8
    Sencha Premium Member
    Join Date
    Jan 2010
    Location
    Vancouver, Canada
    Posts
    137
    Vote Rating
    29
    bogc will become famous soon enough bogc will become famous soon enough

      0  

    Default


    Maybe it is an overstatement, but when the app calls this function in lots of places, you need to visit each one of them, and see exactly what needs to be refactored in order to make it work the way it was before. This adds time to the project.

    Anyway, what's done is done.

  9. #9
    Sencha Premium Member
    Join Date
    Oct 2009
    Posts
    12
    Vote Rating
    0
    schmoboy is on a distinguished road

      0  

    Default Load should be fired for loadRawData

    Load should be fired for loadRawData


    I just ran into the issue with the load event being removed from loadRawData also when upgrading.

    I believe the load event should be fired. If the store was loaded, regardless of how it was loaded, the load event should be fired.

    Imagine the case where one ajax call is used to retrieve meta data. This metatdata contains results for populating multiple stores. One call instead of 10 to load each store via its proxy is more efficient. So the results of this one call are loaded into each store via its loadRawData.

    Now I have multipl UI components that use these stores, so to maintain clean separation these components just listened to the load event for the meta stores. Now you are telling me that the code that calls loadRawData should be aware of something else needing to be notified that the store was loaded and have to fire its own custom event? Makes no sense. The store was loaded, fire the event. Only logical.

    And actually the 4.2.2 docs are incorrect as they state loadRawData actually fires the load event.

  10. #10
    Sencha User makana's Avatar
    Join Date
    Apr 2008
    Location
    Dresden, Germany
    Posts
    527
    Vote Rating
    20
    makana has a spectacular aura about makana has a spectacular aura about

      0  

    Default


    The thing is that loadRawData doesn't depend on any async processing, it must be called directly by the developer, so there's no real need for any events.
    That's a statement I cannot fully agree with.

    We got the following override:
    Code:
    Ext.define('Ext.override.data.Store', {
    	override: 'Ext.data.Store',
    
    	/**
    	 * @inheritdoc
    	 * @localdoc fire load event and set proxy data
    	 */
    	loadRawData: function(data, append)
    	{
    		var me      = this,
    			result  = me.proxy.reader.read(data),
    			records = result.records;
    
    		me.lastOptions = Ext.apply({}, append ? me.addRecordOptions : undefined);
    
    		if (result.success)
    		{
    			// set inline data, e.g. for refresh
    			if (me.proxy instanceof Ext.data.proxy.Memory)
    			{
    				if (append && Ext.isArray(me.proxy.data))
    					me.proxy.data.push.apply(me.proxy.data, me.proxy.reader.getRoot(data))
    				else
    					me.proxy.data = me.proxy.reader.getRoot(data);
    			}
    			
    			// increment totalCount
    			if (append)
    				me.totalCount += result.total;
    			else
    				me.totalCount = result.total;
    
    			me.loadRecords(records, append ? me.addRecordsOptions : undefined);
    		}
    
    		// fire load event
    		if (me.hasListeners.load)
    			me.fireEvent('load', me, records, result.success);
    	},
    	/**
    	 * @inheritdoc
    	 * @localdoc fire load event
    	 */
    	loadData: function(data, append)
    	{
    		var me = this,
    			length = data.length,
    			allData = me.snapshot || me.data, // filtered?
    			dataLen = allData.length, 
    			newData = [],
    			totalCount = me.getTotalCount(),
    			i;
    
    		me.lastOptions = Ext.apply({}, append ? me.addRecordOptions : undefined);
    
    		for (i = 0; i < length; i++)
    			newData.push(this.createModel(data[i]));
    
    		// set inline data, e.g. for refresh
    		if (me.proxy instanceof Ext.data.proxy.Memory)
    			// According to the docs, the proxy's inline data is an array, not an object with total, success, root etc.
    			// We rely on it, otherwise the data config is used in a wrong way.
    			me.proxy.data = (append && me.proxy.data ? me.proxy.data : []).concat(data);
    		
    		this.loadRecords(newData, append ? this.addRecordsOptions : undefined);
    		this.totalCount = (append ? totalCount : 0) + (allData.length - dataLen);
    
    		// fire load event
    		if (this.hasListeners.load)
    			this.fireEvent('load', this, newData, true);
    	}
    });
    The main reason behind this is that the paging toolbar did not update correctly when paging through locally loaded data.

    So I think the statement, that no events are needed isn't correct, since internal components rely on it, the PagingToolbar for example.

    Just some thoughts.

    makana
    Programming today is a race between software engineers striving to build bigger and better Ń–diot-proof programs, and the universe striving to produce bigger and better idiots. So far, the universe is winning. (Rick Cook)

    Enhanced ExtJS adapter for Adobe AIR