In doing this, I noticed that there was now a 1px gap between the bottom of the tab pane header and the tab pane body. It appears that the top of the .x-panel-body is 1px out. So I added to the above scss block:
top: $tab-height + 8px !important; /* 8px is padding on .x-tab-bar-top .x-tab-bar-body */
This changes the top value from 33px to 32px and the tab panel header and body are no longer 1px apart.
This solution is fine, but I just wanted to run it by you guys. Two things concern me:
- Generally the use of !important in css should be avoided. I'd prefer a cleaner way to achieve this.
- The Ext Js code that calculates the top value for .x-panel-body to be 33px is obviously incorrect. Any idea why this happens?
Border, margin and padding all affect the size and positioning of components. CSS (SASS) can be used to get rid of or modify the CSS values but the layouts calculate the sizing of components so thats why there are border, margin and padding configs on the components because the layouts need to know about them.
In theory Ext Js should be able to determine all those values from the dom element and it's associated css properties. But I'm guessing that this doesn't work all the time in all browsers? Or at least not early enough in the page rendering process.
So basically we should do all margin, padding, border via component configs?
If so, that's a shame, but I guess when supporting older browsers you need an infallible approach.
Turkiyenin en sevilen filmlerinin yer aldigi xnxx internet sitemiz olan ve porn sex tarzi bir site olan mobil porno izle sitemiz gercekten dillere destan bir durumda herkesin sevdigi bir site olarak tarihe gececege benziyor. Sitenin en belirgin ozelliklerinden birisi de Turkiyede gercekten kaliteli ve muntazam, duzenli porno izle siteleri olmamasidir. Bu yuzden iste. Ayrica en net goruntu kalitesine sahip adresinde yayinlanmaktadir. Mesela diğer sitelerimizden bahsedecek olursak, en iyi hd porno video arşivine sahip bir siteyiz. "The Best anal porn videos and slut anus, big asses movies set..."